>
> From: Victor Toso <me@xxxxxxxxxxxxxx>
>
> The migration process would happen in idle, so the process only fails
> at a later time. No call to migrate_channel_connect() is actually
> checking the return value.
>
> Signed-off-by: Victor Toso <victortoso@xxxxxxxxxx>
Sure,
Acked-by: Frediano Ziglio <fziglio@xxxxxxxxxx>
The question however is who is owning the pointer?
Why was returned without ownership?
> ---
> src/channel-main.c | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/src/channel-main.c b/src/channel-main.c
> index afdc1ce..a1e5498 100644
> --- a/src/channel-main.c
> +++ b/src/channel-main.c
> @@ -2168,15 +2168,14 @@ static void migrate_channel_new_cb(SpiceSession *s,
> SpiceChannel *channel, gpoin
> G_CALLBACK(migrate_channel_event_cb), data);
> }
>
> -static SpiceChannel* migrate_channel_connect(spice_migrate *mig, int type,
> int id)
> +static void
> +migrate_channel_connect(spice_migrate *mig, int type, int id)
> {
> SPICE_DEBUG("migrate_channel_connect %d:%d", type, id);
>
> SpiceChannel *newc = spice_channel_new(mig->session, type, id);
> spice_channel_connect(newc);
> mig->nchannels++;
> -
> - return newc;
> }
>
> /* coroutine context */
Frediano
_______________________________________________
Spice-devel mailing list
Spice-devel@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/spice-devel