Re: [PATCH spice-protocol] qxl_dev: Add comment to QXLQUICData->data field

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi,

On Thu, Aug 22, 2019 at 08:14:24AM -0400, Frediano Ziglio wrote:
> ping
> 
> > 
> > Recently a bug using this structure was fixed.
> > The bug involved understand the usage of this field so add some
> > note on the field for future reference.
> > 
> > Signed-off-by: Frediano Ziglio <fziglio@xxxxxxxxxx>

Sure,
Acked-by: Victor Toso <victortoso@xxxxxxxxxx>

> > ---
> >  spice/qxl_dev.h | 3 +++
> >  1 file changed, 3 insertions(+)
> > 
> > diff --git a/spice/qxl_dev.h b/spice/qxl_dev.h
> > index c844d7b..3f56aae 100644
> > --- a/spice/qxl_dev.h
> > +++ b/spice/qxl_dev.h
> > @@ -740,6 +740,9 @@ typedef struct SPICE_ATTR_PACKED QXLSurfaceId {
> >  
> >  typedef struct SPICE_ATTR_PACKED QXLQUICData {
> >      uint32_t data_size;
> > +    /* This data for QUIC is a QXLDataChunk.
> > +     * This differs from QXLBitmap where it's a reference to bitmap data or
> > +     * a reference to QXLDataChunk */
> >      uint8_t data[0];
> >  } QXLQUICData, QXLLZRGBData, QXLJPEGData;
> >  
> _______________________________________________
> Spice-devel mailing list
> Spice-devel@xxxxxxxxxxxxxxxxxxxxx
> https://lists.freedesktop.org/mailman/listinfo/spice-devel

Attachment: signature.asc
Description: PGP signature

_______________________________________________
Spice-devel mailing list
Spice-devel@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/spice-devel

[Index of Archives]     [Linux Virtualization]     [Linux Virtualization]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Security]     [Bugtraq]     [Linux OMAP]     [Linux MIPS]     [ECOS]     [Asterisk Internet PBX]     [Linux API]     [Monitors]