> On Thu, Aug 22, 2019 at 1:20 PM Victor Toso <victortoso@xxxxxxxxxx> wrote: > > > > Hi, > > > > On Mon, Aug 12, 2019 at 12:57:20PM +0300, Yuri Benditovich wrote: > > > This series of patches adds feature of sharing CD image via > > > redirection of emulated CD device. Currently the trigger to > > > create the device is command-line option: > > > '--spice-share-cd <ISO file name> > > > > > > Changes from v2: fixes resulted by reviews (based on fixups > > > of Frediano Ziglio) > > > > > > Changes from v1: fixes resulted by reviews (mainly based on fixups > > > of Frediano Ziglio) > > > > > > Frediano Ziglio (1): > > > usb-redir: cosmetic style fixes > > > > > > Yuri Benditovich (8): > > > usb-redir: define interfaces to support emulated devices > > > usb-redir: move implementation of device description to USB backend > > > usb-redir: do not use spice_usb_acl_helper for emulated devices > > > usb-redir: extend USB backend to support emulated devices > > > usb-redir: add files for SCSI and USB MSC implementation > > > usb-redir: add implementation of emulated CD device > > > usb-redir: enable redirection of emulated CD drive > > > usb-redir: command-line option to create emulated CD drive > > > > > > src/cd-scsi-dev-params.h | 49 + > > > src/cd-scsi.c | 2740 ++++++++++++++++++++++++++++++++++++++ > > > src/cd-scsi.h | 120 ++ > > > src/cd-usb-bulk-msd.c | 544 ++++++++ > > > src/cd-usb-bulk-msd.h | 134 ++ > > > src/channel-usbredir.c | 31 +- > > > src/meson.build | 8 + > > > src/scsi-constants.h | 324 +++++ > > > src/spice-option.c | 17 + > > > src/usb-backend.c | 777 ++++++++++- > > > src/usb-backend.h | 4 + > > > src/usb-device-cd.c | 783 +++++++++++ > > > src/usb-device-cd.h | 34 + > > > src/usb-device-manager.c | 63 +- > > > src/usb-emulation.h | 88 ++ > > > > It is a shame that no unit tests were added. Do you plan to do it > > in future patchsets? > > How many features in spice-gtk do have unit tests and how many do not? > This is not answering what Victor asked. He asked if you plan to add some new tests. As I said in a previous reply the company is asking us to improve testing in the code. Frediano _______________________________________________ Spice-devel mailing list Spice-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/spice-devel