Hi, updated series and proposed some follow ups. Some patches are just styles, some minor fixes. One is the proposed change to reference counting of SpiceUsbBackendDevice already discussed and sent on ML. Added also a test to test some leaks (to fully detect it requires the configuration of some tool like Valgrind or code sanitizers) Improved a bit the CI detecting errors compiling and compiling USB part on Windows (related but not strictly of this series). The review was more focused on SCSI emulation part. For easiness to apply the series can be found at https://cgit.freedesktop.org/~fziglio/spice-gtk/log/?h=send Frediano Ziglio (25): fixup! usb-redir: define interfaces to support emulated devices fixup! usb-redir: define interfaces to support emulated devices fixup! usb-redir: extend USB backend to support emulated devices fixup! usb-redir: add files for SCSI and USB MSC implementation fixup! usb-redir: add files for SCSI and USB MSC implementation fixup! usb-redir: add files for SCSI and USB MSC implementation fixup! usb-redir: add files for SCSI and USB MSC implementation fixup! usb-redir: add files for SCSI and USB MSC implementation fixup! usb-redir: add files for SCSI and USB MSC implementation fixup! usb-redir: add files for SCSI and USB MSC implementation fixup! usb-redir: add files for SCSI and USB MSC implementation fixup! usb-redir: add files for SCSI and USB MSC implementation fixup! usb-redir: add files for SCSI and USB MSC implementation fixup! usb-redir: add files for SCSI and USB MSC implementation fixup! usb-redir: add files for SCSI and USB MSC implementation fixup! usb-redir: add files for SCSI and USB MSC implementation fixup! usb-redir: add files for SCSI and USB MSC implementation fixup! usb-redir: add files for SCSI and USB MSC implementation fixup! usb-redir: add implementation of emulated CD device fixup! usb-redir: add implementation of emulated CD device fixup! usb-redir: add implementation of emulated CD device fixup! usb-redir: add implementation of emulated CD device usb-redir: Add base test for cd-emulation CI: Add --werror CI: Add usbredir packages to Windows Yuri Benditovich (8): usb-redir: define interfaces to support emulated devices usb-redir: move implementation of device description to USB backend usb-redir: do not use spice_usb_acl_helper for emulated devices usb-redir: extend USB backend to support emulated devices usb-redir: add files for SCSI and USB MSC implementation usb-redir: add implementation of emulated CD device usb-redir: enable redirection of emulated CD drive usb-redir: command-line option to create emulated CD drive .gitlab-ci.yml | 11 +- src/cd-scsi-dev-params.h | 49 + src/cd-scsi.c | 2740 ++++++++++++++++++++++++++++++++++++++ src/cd-scsi.h | 120 ++ src/cd-usb-bulk-msd.c | 544 ++++++++ src/cd-usb-bulk-msd.h | 134 ++ src/channel-usbredir.c | 31 +- src/meson.build | 8 + src/scsi-constants.h | 324 +++++ src/spice-option.c | 17 + src/usb-backend.c | 777 ++++++++++- src/usb-backend.h | 4 + src/usb-device-cd.c | 783 +++++++++++ src/usb-device-cd.h | 37 + src/usb-device-manager.c | 63 +- src/usb-emulation.h | 91 ++ tests/cd-emu.c | 92 ++ tests/meson.build | 4 + 18 files changed, 5736 insertions(+), 93 deletions(-) create mode 100644 src/cd-scsi-dev-params.h create mode 100644 src/cd-scsi.c create mode 100644 src/cd-scsi.h create mode 100644 src/cd-usb-bulk-msd.c create mode 100644 src/cd-usb-bulk-msd.h create mode 100644 src/scsi-constants.h create mode 100644 src/usb-device-cd.c create mode 100644 src/usb-device-cd.h create mode 100644 src/usb-emulation.h create mode 100644 tests/cd-emu.c -- 2.20.1 _______________________________________________ Spice-devel mailing list Spice-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/spice-devel