Re: [protocol] protocol: Add some comments to vd_agentd.h

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, 1 Aug 2019, Frediano Ziglio wrote:
[...]
> > @@ -254,7 +261,7 @@ typedef struct SPICE_ATTR_PACKED VDAgentDeviceDisplayInfo
> > {
> >      uint32_t monitor_id;
> >      uint32_t device_display_id;
> >      uint32_t device_address_len;
> > -    uint8_t device_address[0];  // a zero-terminated string
> > +    uint8_t device_address[0];  /* a zero-terminated string */
> 
> Not really strong about it.

It's the only place where a C++-style comment is used which makes it 
inconsistent with the style of the rest of the code.


> Can I send an update to this patch ?

Sure.
I'm fine with the proposed changes.


-- 
Francois Gouget <fgouget@xxxxxxxxxxxxxxx>
_______________________________________________
Spice-devel mailing list
Spice-devel@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/spice-devel




[Index of Archives]     [Linux Virtualization]     [Linux Virtualization]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Security]     [Bugtraq]     [Linux OMAP]     [Linux MIPS]     [ECOS]     [Asterisk Internet PBX]     [Linux API]     [Monitors]