ping > > ping > > > > > ping > > > > > > > > ping > > > > > > > > > > > ping > > > > > > > > > > > > > > ping > > > > > > > > > > > > > > > > > ping > > > > > > > > > > > > > > > > > > > > g_object_unref is directly used. > > > > > > > > > > > > > > Signed-off-by: Frediano Ziglio <fziglio@xxxxxxxxxx> > > > > > > > --- > > > > > > > server/char-device.c | 6 ------ > > > > > > > server/char-device.h | 5 ++--- > > > > > > > 2 files changed, 2 insertions(+), 9 deletions(-) > > > > > > > > > > > > > > diff --git a/server/char-device.c b/server/char-device.c > > > > > > > index 9ee255664..0f6a29d6f 100644 > > > > > > > --- a/server/char-device.c > > > > > > > +++ b/server/char-device.c > > > > > > > @@ -697,12 +697,6 @@ void > > > > > > > red_char_device_reset_dev_instance(RedCharDevice > > > > > > > *dev, > > > > > > > g_object_notify(G_OBJECT(dev), "sin"); > > > > > > > } > > > > > > > > > > > > > > -void red_char_device_destroy(RedCharDevice *char_dev) > > > > > > > -{ > > > > > > > - g_return_if_fail(RED_IS_CHAR_DEVICE(char_dev)); > > > > > > > - g_object_unref(char_dev); > > > > > > > -} > > > > > > > - > > > > > > > static RedCharDeviceClient *red_char_device_client_new(RedClient > > > > > > > *client, > > > > > > > int > > > > > > > do_flow_control, > > > > > > > uint32_t > > > > > > > max_send_queue_size, > > > > > > > diff --git a/server/char-device.h b/server/char-device.h > > > > > > > index 893d3e4b1..415d4f17c 100644 > > > > > > > --- a/server/char-device.h > > > > > > > +++ b/server/char-device.h > > > > > > > @@ -91,7 +91,7 @@ GType red_char_device_get_type(void) > > > > > > > G_GNUC_CONST; > > > > > > > * How to use the api: > > > > > > > * ================== > > > > > > > * device attached: create new object instantiating a > > > > > > > RedCharDevice > > > > > > > child > > > > > > > class > > > > > > > - * device detached: call red_char_device_destroy/reset > > > > > > > + * device detached: call g_object_unref/red_char_device_reset > > > > > > > * > > > > > > > * client connected and associated with a device: > > > > > > > red_char_device__add > > > > > > > * client disconnected: red_char_device__remove > > > > > > > @@ -120,7 +120,7 @@ GType red_char_device_get_type(void) > > > > > > > G_GNUC_CONST; > > > > > > > * red_char_device_wakeup (for reading from the device) > > > > > > > */ > > > > > > > /* refcounting is used to protect the char_dev from being > > > > > > > deallocated > > > > > > > in > > > > > > > - * case red_char_device_destroy has been called > > > > > > > + * case g_object_unref has been called > > > > > > > * during a callback, and we might still access the char_dev > > > > > > > afterwards. > > > > > > > */ > > > > > > > > > > > > > > @@ -160,7 +160,6 @@ typedef struct RedCharDeviceWriteBuffer { > > > > > > > > > > > > > > void red_char_device_reset_dev_instance(RedCharDevice *dev, > > > > > > > SpiceCharDeviceInstance > > > > > > > *sin); > > > > > > > -void red_char_device_destroy(RedCharDevice *dev); > > > > > > > > > > > > > > /* only one client is supported */ > > > > > > > void red_char_device_migrate_data_marshall(RedCharDevice *dev, > _______________________________________________ > Spice-devel mailing list > Spice-devel@xxxxxxxxxxxxxxxxxxxxx > https://lists.freedesktop.org/mailman/listinfo/spice-devel _______________________________________________ Spice-devel mailing list Spice-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/spice-devel