On 7/22/19 5:16 AM, Frediano Ziglio wrote:
Signed-off-by: Jeremy White <jwhite@xxxxxxxxxxxxxxx>
I didn't expected you would change everything :-)
:-).
Well, I appreciate the review, so when the suggestions are easy, I try
to be responsive.
- p = options->spice_password = malloc(options->generate_password + 1);
+ p = options->spice_password = g_malloc(options->generate_password + 1);
if (!p)
g_malloc never returns NULL. Do you want to remove the check and accept
the abort() or use g_try_malloc ? I suppose the first giving the above code
and the fact that many old strdup assumed strdup never returned NULL.
Yeah, abort is perfectly fine. I resent this patch.
Cheers,
Jeremy
_______________________________________________
Spice-devel mailing list
Spice-devel@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/spice-devel