Re: [spice-server PATCH v2 2/3] dcc-send: remove unused variable 'image'

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Jul 11, 2019 at 04:27:27AM -0400, Frediano Ziglio wrote:
> > 
> > From: Frediano Ziglio <fziglio@xxxxxxxxxx>
> > 
> > Signed-off-by: Frediano Ziglio <fziglio@xxxxxxxxxx>
> 
> I supposed someone else should ack it

Two maintainers agreeing should be enough, but hey
Acked-by: Victor Toso <victortoso@xxxxxxxxxx>

> 
> > ---
> >  server/dcc-send.c | 6 ++----
> >  1 file changed, 2 insertions(+), 4 deletions(-)
> > 
> > diff --git a/server/dcc-send.c b/server/dcc-send.c
> > index 565a79f33..e0f3b8183 100644
> > --- a/server/dcc-send.c
> > +++ b/server/dcc-send.c
> > @@ -725,7 +725,6 @@ static void
> > red_pipe_replace_rendered_drawables_with_images(DisplayChannelClient
> >          RedPipeItem *pipe_item = l->data;
> >          Drawable *drawable;
> >          RedDrawablePipeItem *dpi;
> > -        RedImageItem *image;
> >  
> >          if (pipe_item->type != RED_PIPE_ITEM_TYPE_DRAW)
> >              continue;
> > @@ -745,13 +744,12 @@ static void
> > red_pipe_replace_rendered_drawables_with_images(DisplayChannelClient
> >              continue;
> >          }
> >  
> > -        image = dcc_add_surface_area_image(dcc,
> > drawable->red_drawable->surface_id,
> > -                                           &drawable->red_drawable->bbox, l,
> > TRUE);
> > +        dcc_add_surface_area_image(dcc, drawable->red_drawable->surface_id,
> > +                                   &drawable->red_drawable->bbox, l, TRUE);
> >          resent_surface_ids[num_resent] = drawable->red_drawable->surface_id;
> >          resent_areas[num_resent] = drawable->red_drawable->bbox;
> >          num_resent++;
> >  
> > -        spice_assert(image);
> >          red_channel_client_pipe_remove_and_release_pos(RED_CHANNEL_CLIENT(dcc),
> >          l);
> >      }
> >  }
> 
> Frediano
> _______________________________________________
> Spice-devel mailing list
> Spice-devel@xxxxxxxxxxxxxxxxxxxxx
> https://lists.freedesktop.org/mailman/listinfo/spice-devel

Attachment: signature.asc
Description: PGP signature

_______________________________________________
Spice-devel mailing list
Spice-devel@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/spice-devel

[Index of Archives]     [Linux Virtualization]     [Linux Virtualization]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Security]     [Bugtraq]     [Linux OMAP]     [Linux MIPS]     [ECOS]     [Asterisk Internet PBX]     [Linux API]     [Monitors]