In red_pipe_replace_rendered_drawables_with_images, the value of pipe_item is re-written on the next iteration. Since a78a7d251042892182b158650291d19a85bbd6b1 pipe_item is no longer used to control the loop. Found by Covscan. Signed-off-by: Uri Lublin <uril@xxxxxxxxxx> --- server/dcc-send.c | 1 - 1 file changed, 1 deletion(-) diff --git a/server/dcc-send.c b/server/dcc-send.c index b14619a2b..565a79f33 100644 --- a/server/dcc-send.c +++ b/server/dcc-send.c @@ -753,7 +753,6 @@ static void red_pipe_replace_rendered_drawables_with_images(DisplayChannelClient spice_assert(image); red_channel_client_pipe_remove_and_release_pos(RED_CHANNEL_CLIENT(dcc), l); - pipe_item = &image->base; } } -- 2.21.0 _______________________________________________ Spice-devel mailing list Spice-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/spice-devel