Re: [PATCH spice-server] test-codecs-parsing: On bad codec string spice_server_set_video_codecs can fail

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi,

On 7/5/19 4:09 PM, Frediano Ziglio wrote:
The 0 result means success however the function (correctly) could
report a failure if the string is incorrect.
This fixes the test after commit b4150de3cd0e56d4ce43a99ef5c3c5f5cbdfc4a3
("spice_server_set_video_codecs: fail when no codec can be installed").

Signed-off-by: Frediano Ziglio <fziglio@xxxxxxxxxx>
---
  server/tests/test-codecs-parsing.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/server/tests/test-codecs-parsing.c b/server/tests/test-codecs-parsing.c
index 7998501c9..08d83cc2b 100644
--- a/server/tests/test-codecs-parsing.c
+++ b/server/tests/test-codecs-parsing.c
@@ -140,7 +140,7 @@ static void codecs_bad(void)
          g_test_expect_message(G_LOG_DOMAIN, test_cases[i].log_level, test_cases[i].error_message);
          if (test_cases[i].default_err_message)
              g_test_expect_message(G_LOG_DOMAIN, G_LOG_LEVEL_WARNING, "*Failed to set video codecs*");
-        g_assert_cmpint(spice_server_set_video_codecs(server, test_cases[i].codecs), ==, 0);
+        spice_server_set_video_codecs(server, test_cases[i].codecs);


Can't we assert for  -1 now?

Snir.

          g_test_assert_expected_messages();
      }
_______________________________________________
Spice-devel mailing list
Spice-devel@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/spice-devel




[Index of Archives]     [Linux Virtualization]     [Linux Virtualization]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Security]     [Bugtraq]     [Linux OMAP]     [Linux MIPS]     [ECOS]     [Asterisk Internet PBX]     [Linux API]     [Monitors]