Re: [PATCH spice-server] build: Fix M4 macros quoting

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, May 07, 2019 at 02:52:05PM +0100, Frediano Ziglio wrote:
> The PKG_CHECK_MODULES macro were not expanded correctly causing
> the gio-unix module not to be detected and these warnings:
> 
> ../configure: line 15133: GIO_UNIX_CFLAGS: command not found
> ../configure: line 15134: C: command not found
> ../configure: line 15135: GIO_UNIX_LIBS: command not found
> ../configure: line 15136: linker: command not found
> 
> Signed-off-by: Frediano Ziglio <fziglio@xxxxxxxxxx>
> ---
>  configure.ac | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/configure.ac b/configure.ac
> index 8bcb22ce..e12d7e85 100644
> --- a/configure.ac
> +++ b/configure.ac
> @@ -194,7 +194,7 @@ AS_VAR_APPEND([SPICE_REQUIRES], [" gobject-2.0 >= $GLIB2_REQUIRED"])
>  
>  #used only by tests
>  AS_IF([test "x$os_win32" != "xyes"],
> -      PKG_CHECK_MODULES([GIO_UNIX], [gio-unix-2.0 >= $GLIB2_REQUIRED]))
> +      [PKG_CHECK_MODULES([GIO_UNIX], [gio-unix-2.0 >= $GLIB2_REQUIRED])])

Sure,
Acked-by: Victor Toso <victortoso@xxxxxxxxxx>

>  
>  PIXMAN_REQUIRED=0.17.7
>  PKG_CHECK_MODULES(PIXMAN, pixman-1 >= $PIXMAN_REQUIRED)
> -- 
> 2.20.1
> 
> _______________________________________________
> Spice-devel mailing list
> Spice-devel@xxxxxxxxxxxxxxxxxxxxx
> https://lists.freedesktop.org/mailman/listinfo/spice-devel

Attachment: signature.asc
Description: PGP signature

_______________________________________________
Spice-devel mailing list
Spice-devel@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/spice-devel

[Index of Archives]     [Linux Virtualization]     [Linux Virtualization]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Security]     [Bugtraq]     [Linux OMAP]     [Linux MIPS]     [ECOS]     [Asterisk Internet PBX]     [Linux API]     [Monitors]