From: Victor Toso <me@xxxxxxxxxxxxxx> Hi, While looking at channel-usbredir code, seems weird that we are ifdef USE_POLKIT on usb-acl-helper function that itself does not link with polkit but runs the binary spice-client-glib-usb-acl-helper that links to polkit library. This patchset suggestion is to keep the access control helper to work without polkit in order to remove the polkit build logic from channel-usbredir. That means always building usb-acl-helper and I don't see a strong reason not to. Tested on Fedora 29 with polkit and without. Cheers, Victor Gitlab-ci: https://gitlab.freedesktop.org/victortoso/spice-gtk/pipelines/35468 Victor Toso (4): usb-acl-helper: move exec of binary to its own function usb-acl-helper: always build access control helper channel-usbredir: use mutex on polkit code path channel-usbredir: move polkit related checks to usb-acl-helper src/Makefile.am | 13 +---- src/channel-usbredir.c | 54 ++---------------- src/meson.build | 7 +-- src/usb-acl-helper.c | 124 +++++++++++++++++++++++++++-------------- 4 files changed, 90 insertions(+), 108 deletions(-) -- 2.20.1 _______________________________________________ Spice-devel mailing list Spice-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/spice-devel