Re: [PATCH spice-server 2/3] Update spice-protocol version

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi,

On Fri, Apr 26, 2019 at 11:22:29AM +0100, Frediano Ziglio wrote:
> We require version after 0.12.15 which will be released as 0.14.0.

* was released.

What I said in linux/vd-agent was 'to check against a valid
released instead of checking with a non existing one', that is,
0.12.16

    https://gitlab.freedesktop.org/spice/linux/vd_agent/commit/c47e073385e418ba9489

> Signed-off-by: Frediano Ziglio <fziglio@xxxxxxxxxx>

Either way, patch looks fine
    Acked-by: Victor Toso <victortoso@xxxxxxxxxx>

> ---
>  README       | 2 +-
>  configure.ac | 2 +-
>  meson.build  | 2 +-
>  3 files changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/README b/README
> index 0905fe5b4..73286a537 100644
> --- a/README
> +++ b/README
> @@ -27,7 +27,7 @@ Or to install into a private user specific location
>  The following mandatory dependencies are required in order to
>  build SPICE
>  
> -    Spice protocol >= 0.12.14
> +    Spice protocol >= 0.14.0
>      Pixman         >= 0.17.7
>      OpenSSL
>      libjpeg
> diff --git a/configure.ac b/configure.ac
> index 9a8f4504c..4a4704274 100644
> --- a/configure.ac
> +++ b/configure.ac
> @@ -161,7 +161,7 @@ AS_IF([test x"$have_smartcard" = "xyes"], [
>      AS_VAR_APPEND([SPICE_REQUIRES], [" libcacard >= 2.5.1"])
>  ])
>  
> -SPICE_PROTOCOL_MIN_VER=0.12.16
> +SPICE_PROTOCOL_MIN_VER=0.14.0
>  PKG_CHECK_MODULES([SPICE_PROTOCOL], [spice-protocol >= $SPICE_PROTOCOL_MIN_VER])
>  AC_SUBST([SPICE_PROTOCOL_MIN_VER])
>  
> diff --git a/meson.build b/meson.build
> index 1b07f30d5..2951561fd 100644
> --- a/meson.build
> +++ b/meson.build
> @@ -81,7 +81,7 @@ endif
>  #
>  # check for mandatory dependencies
>  #
> -spice_protocol_version='0.12.16'
> +spice_protocol_version='0.14.0'
>  
>  glib_version = '2.38'
>  glib_version_info = '>= @0@'.format(glib_version)
> -- 
> 2.20.1
> 
> _______________________________________________
> Spice-devel mailing list
> Spice-devel@xxxxxxxxxxxxxxxxxxxxx
> https://lists.freedesktop.org/mailman/listinfo/spice-devel

Attachment: signature.asc
Description: PGP signature

_______________________________________________
Spice-devel mailing list
Spice-devel@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/spice-devel

[Index of Archives]     [Linux Virtualization]     [Linux Virtualization]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Security]     [Bugtraq]     [Linux OMAP]     [Linux MIPS]     [ECOS]     [Asterisk Internet PBX]     [Linux API]     [Monitors]