Re: [PATCH linux/vd-agent 01/11] Add a .gitpublish

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



> 
> Hi,
> 
> On Fri, Mar 22, 2019 at 04:12:36PM +0100, marcandre.lureau@xxxxxxxxxx wrote:
> > From: Marc-André Lureau <marcandre.lureau@xxxxxxxxxx>
> > 
> > Set a default profile for git-publish.
> > (https://github.com/stefanha/git-publish)
> > 
> > Signed-off-by: Marc-André Lureau <marcandre.lureau@xxxxxxxxxx>
> > ---
> >  .gitpublish | 4 ++++
> >  1 file changed, 4 insertions(+)
> >  create mode 100644 .gitpublish
> > 
> > diff --git a/.gitpublish b/.gitpublish
> > new file mode 100644
> > index 0000000..71a9478
> > --- /dev/null
> > +++ b/.gitpublish
> > @@ -0,0 +1,4 @@
> > +[gitpublishprofile "default"]
> > +to = spice-devel@xxxxxxxxxxxxxxxxxxxxx
> > +prefix = PATCH linux/vd-agent
> > +signoff = true
> 
> I agree with Daniel in his reply on spice-protocol
> 
>     https://lists.freedesktop.org/archives/spice-devel/2019-March/048600.html
> 
> If you don't mind changing that:
> 
>     Acked-by: Victor Toso <victortoso@xxxxxxxxxx>
> 

I agree with Daniel.
However if you have the file in the repository but you want to change it
on your working directory it could be a bit of pain as you'll have for
instance to stash the change in order to do a rebase.
Personally I don't use it and I signed manually so won't be a problem
for me (so still ack for me) but potentially would be more complex
than simply copy manually the file after the clone.

Frediano
_______________________________________________
Spice-devel mailing list
Spice-devel@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/spice-devel




[Index of Archives]     [Linux Virtualization]     [Linux Virtualization]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Security]     [Bugtraq]     [Linux OMAP]     [Linux MIPS]     [ECOS]     [Asterisk Internet PBX]     [Linux API]     [Monitors]