Hi,
On Wed, Apr 03, 2019 at 09:53:21AM +0100, Frediano Ziglio wrote:
> RecoderChannel::data message is the same as PlaybackChannel::data
> one.
> This fixed compilation of spice-gtk using updated spice-common.
>
> Before generating the messages automatically the definition was:
>
> typedef struct SpiceMsgPlaybackPacket {
> uint32_t time;
> uint8_t *data;
> uint32_t data_size;
> } SpiceMsgPlaybackPacket, SpiceMsgcRecordPacket;
>
> so both messages were defined as struct SpiceMsgPlaybackPacket with
> SpiceMsgcRecordPacket an alias to it.
>
> But spice.proto for RecordChannel::data was changed from
> SpiceMsgcRecordPacket (the alias) to SpiceMsgcPlaybackPacket
> defining a new structure and breaking the alias.
>
> Signed-off-by: Frediano Ziglio <fziglio@xxxxxxxxxx>
Thanks for the clarification,
Acked-by: Victor Toso <victortoso@xxxxxxxxxx>
> ---
> spice.proto | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> Changes since v1:
> - commit message with more explanations.
>
> diff --git a/spice.proto b/spice.proto
> index 1f9f57b..3bbec0c 100644
> --- a/spice.proto
> +++ b/spice.proto
> @@ -1222,7 +1222,7 @@ channel RecordChannel : BaseChannel {
> message {
> uint32 time;
> uint8 data[] @nomarshal @as_ptr(data_size);
> - } @ctype(SpiceMsgcPlaybackPacket) @declare data = 101;
> + } @ctype(SpiceMsgPlaybackPacket) @declare data = 101;
>
> message {
> uint32 time;
> --
> 2.20.1
>
> _______________________________________________
> Spice-devel mailing list
> Spice-devel@xxxxxxxxxxxxxxxxxxxxx
> https://lists.freedesktop.org/mailman/listinfo/spice-devel
Attachment:
signature.asc
Description: PGP signature
_______________________________________________ Spice-devel mailing list Spice-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/spice-devel