Hey, Overall series looks good to me, you seem to have ignored most of the suggestions to change the commit logs/comments, I dunno if that's intentional? Still a few comments on "win-usb-dev: maintain list of libusb devices" So apart from this patch, Acked-by: Christophe Fergeau <cfergeau@xxxxxxxxxx> Christophe On Tue, Mar 19, 2019 at 07:55:55AM +0200, Yuri Benditovich wrote: > This series unifies part of USB redirection code for Windows making > it the same as for Linux by using persistent libusb_device also on > Windows. > > Changes from v1: > minor fixes per v1 review > rebase to latest master branch > > Yuri Benditovich (13): > usb-redir: replace USE_GUDEV with G_OS_WIN32 > usb-redir: remove unused 'subsystem' parameter > usb-redir: reuse libusb context under Windows > usb-redir: do not add device if one with the same bus:addr exists > win-usb-dev: strict comparison of USB devices > win-usb-dev: remove unused procedure > usb-redir: discard cold-plug device list under Windows > usb-redir: change signal prototype of win-usb-dev > win-usb-dev: do not allocate memory for hub devices > win-usb-dev: maintain list of libusb devices > win-usb-dev: report libusb_device via signal > usb-redir: use persistent libusb_device under Windows also > win-usb-dev: remove unused code > > src/spice-marshal.txt | 1 + > src/usb-device-manager.c | 267 ++++++--------------------------------- > src/win-usb-dev.c | 254 ++++++++++--------------------------- > src/win-usb-dev.h | 35 +---- > 4 files changed, 110 insertions(+), 447 deletions(-) > > -- > 2.17.1 > > _______________________________________________ > Spice-devel mailing list > Spice-devel@xxxxxxxxxxxxxxxxxxxxx > https://lists.freedesktop.org/mailman/listinfo/spice-devel
Attachment:
signature.asc
Description: PGP signature
_______________________________________________ Spice-devel mailing list Spice-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/spice-devel