Re: [PATCH spice-server v2] Move channel registration to constructed vfunc

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, 2019-03-15 at 05:05 -0400, Frediano Ziglio wrote:
> > 
> > For the Display Channel and the Cursor channel, move the call to
> > reds_register_channel() to the _constructed() vfunc rather than
> > calling
> > it explicitly from RedWorker. This matches what other channels do.
> > ---
> > Changes in v2:
> >  - remove cursor channel registration in stream device
> > 
> > Note that I didn't implement a couple other suggestions from
> > Frediano's first
> > review. Reference
> > earlier email reply for justification.
> > 
> 
> Why this comment? Were you waiting for my reply?
> I though was the normal review process and I had no reason to reply.
> Did I misunderstand?
> 

No, I was just explaining why I didn't change some things that you had
suggested in your first review. It took a little while between my
initial patch and this one, so I thought I'd provide a bit more context
in case you had forgotten.

Jonathon

_______________________________________________
Spice-devel mailing list
Spice-devel@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/spice-devel




[Index of Archives]     [Linux Virtualization]     [Linux Virtualization]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Security]     [Bugtraq]     [Linux OMAP]     [Linux MIPS]     [ECOS]     [Asterisk Internet PBX]     [Linux API]     [Monitors]