On Mon, Mar 11, 2019 at 7:07 PM Christophe Fergeau <cfergeau@xxxxxxxxxx> wrote:
>
> On Sun, Mar 10, 2019 at 04:46:01PM +0200, Yuri Benditovich wrote:
> > Removing unused parameter for GUdevClient constructor.
>
> I'd explicitly mention that it's possible because we no longer use the
> external libgudev, and at this point g_udev_client_new() is just
> internal API used by the windows code.
>
This was mentioned in previous commit.
This code is compiled under 'windows only' ifdef.
As I'm not able to guess how you will want to rephrase commit message please
feel free to change commit message for any submitted commit as you want.
> Apart from this minor comment,
> Acked-by: Christophe Fergeau <cfergeau@xxxxxxxxxx>
>
> Christophe
>
> >
> > Signed-off-by: Yuri Benditovich <yuri.benditovich@xxxxxxxxxx>
> > ---
> > src/usb-device-manager.c | 5 +----
> > src/win-usb-dev.c | 2 +-
> > src/win-usb-dev.h | 2 +-
> > 3 files changed, 3 insertions(+), 6 deletions(-)
> >
> > diff --git a/src/usb-device-manager.c b/src/usb-device-manager.c
> > index 6a36cfa..6435be8 100644
> > --- a/src/usb-device-manager.c
> > +++ b/src/usb-device-manager.c
> > @@ -283,9 +283,6 @@ static gboolean spice_usb_device_manager_initable_init(GInitable *initable,
> > GList *list;
> > GList *it;
> > int rc;
> > -#ifdef G_OS_WIN32
> > - const gchar *const subsystems[] = {"usb", NULL};
> > -#endif
> >
> > /* Initialize libusb */
> > rc = libusb_init(&priv->context);
> > @@ -305,7 +302,7 @@ static gboolean spice_usb_device_manager_initable_init(GInitable *initable,
> >
> > /* Start listening for usb devices plug / unplug */
> > #ifdef G_OS_WIN32
> > - priv->udev = g_udev_client_new(subsystems);
> > + priv->udev = g_udev_client_new();
> > if (priv->udev == NULL) {
> > g_warning("Error initializing GUdevClient");
> > return FALSE;
> > diff --git a/src/win-usb-dev.c b/src/win-usb-dev.c
> > index 327976d..d0eae06 100644
> > --- a/src/win-usb-dev.c
> > +++ b/src/win-usb-dev.c
> > @@ -104,7 +104,7 @@ GQuark g_udev_client_error_quark(void)
> > return g_quark_from_static_string("win-gudev-client-error-quark");
> > }
> >
> > -GUdevClient *g_udev_client_new(const gchar* const *subsystems)
> > +GUdevClient *g_udev_client_new(void)
> > {
> > if (singleton != NULL)
> > return g_object_ref(singleton);
> > diff --git a/src/win-usb-dev.h b/src/win-usb-dev.h
> > index 7f40197..0f34a01 100644
> > --- a/src/win-usb-dev.h
> > +++ b/src/win-usb-dev.h
> > @@ -79,7 +79,7 @@ struct _GUdevClientClass
> > };
> >
> > GType g_udev_client_get_type(void) G_GNUC_CONST;
> > -GUdevClient *g_udev_client_new(const gchar* const *subsystems);
> > +GUdevClient *g_udev_client_new(void);
> > GList *g_udev_client_query_by_subsystem(GUdevClient *client, const gchar *subsystem);
> >
> > GType g_udev_device_get_type(void) G_GNUC_CONST;
> > --
> > 2.17.1
> >
> > _______________________________________________
> > Spice-devel mailing list
> > Spice-devel@xxxxxxxxxxxxxxxxxxxxx
> > https://lists.freedesktop.org/mailman/listinfo/spice-devel
> -----BEGIN PGP SIGNATURE-----
>
> iQIzBAEBCAAdFiEElKn3VmH3emFoZJsjqdjCFCmsbIIFAlyGlckACgkQqdjCFCms
> bIINmg/+PFRXnEPoohc11zADTHEUoz1lmPKpOCsYwIlhG1nDkeqjk6cqfwNzOxWb
> c7K9A3LzvWkVkMcw2otSmd/PoQ3Dv0adbFC95MmQzbYYx/UIvB2uwnntZqamdkNY
> WeuCZAHThpLx7vK03b/8BlBeygh3yiQ3Csg50tAzVYi1ASNIFrTtQeaEzJqXexRq
> 5tymwksjG4RBZAaYVyYu+KFMSmeM/4NPWY0re/HKRRwF0XCjg5ism8r87NiEn6CF
> 0hoz3Zrwtbxq+0vCBexaUK3a3AODSWUb49FhkaFRcmfRWzKIbVBBpriiKE2NZYL2
> 9TRgcWYyyi7vQyvL9hI1whKUy4Vsyu69Xy7eY3Z6mrKh/dDLkyITy5iQ9n6bORu2
> 2/Ks8DQ+a1tc/fpzYwiA06BQtCag8HvPwqEagzsRsfcnneEU1HMCN8z1Gs5k2Q3F
> I8LeCpfNZE5EIYHfrL6qat+DE6D/EvAOECOA+iRv+o/yHbAVPEg1+vn8Xoo8b2cy
> fjqjU/cENkw7jjP3t6rLpy6V33cGXrC4utOOZll4aRLNHZuOQwxUrINmBCGeQbzv
> RXeRaGCN5qm/rimsqn+XDcJmRI7pc4Fjv08QjhWYG/UL8hfKUXuzwMjlJub7mWd0
> mbzrITjwhbV74OxO3XrI2AcAKqItHoMcrw4ZIxRJD64yse2e9nw=
> =8Xhv
> -----END PGP SIGNATURE-----
_______________________________________________
Spice-devel mailing list
Spice-devel@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/spice-devel