Re: [PATCH spice-common 6/9] Generate automatically most C message declarations

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



> 
> Acked-by: Christophe Fergeau <cfergeau@xxxxxxxxxx>
> 
> only one caveat is that some of the structs are getting renamed to
> equivalent ones (SpiceMsgDisplayDrawBlend/SpiceMsgDisplayDrawCopy,
> SpiceMsgcMainAgentStart/SpiceMsgcMainAgentTokens and a few more), which
> is fine because they are typedef'ed to the other type anyway
> I guess it's worth mentioned in the commit log.
> 

Original code did something similar, like

  typedef struct SpiceMsgMainAgentTokens {
      uint32_t num_tokens;
  } SpiceMsgMainAgentTokens, SpiceMsgcMainAgentTokens, SpiceMsgcMainAgentStart;

just now is more evident because all the typedefs are in the same place.

> Reviewed-by: Christophe Fergeau <cfergeau@xxxxxxxxxx>
> 
> Christophe
> 

... omissis ...

Frediano
_______________________________________________
Spice-devel mailing list
Spice-devel@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/spice-devel




[Index of Archives]     [Linux Virtualization]     [Linux Virtualization]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Security]     [Bugtraq]     [Linux OMAP]     [Linux MIPS]     [ECOS]     [Asterisk Internet PBX]     [Linux API]     [Monitors]