Re: [PATCH spice-common 9/9] codegen: Rename --prefix parameter to --suffix

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



> 
> On Sun, Mar 03, 2019 at 07:10:30PM +0000, Frediano Ziglio wrote:
> > The option is used to add a suffix to public functions, not a
> > prefix.
> 
> Sometimes it's a suffix to a prefix, sometimes it's indeed just a
> suffix. So your change makes sense.
> 

I cannot find any place where is used as a "suffix to a prefix",
it's always appended to a partial function name.

> > Currently the option is not used (it was used to generate protocol
> > 1 code).
> 
> Why not remove it? It's inconsistent with the commit saying ptr_size is
> unused so it can be removed.
> 

Yes, I think 7/9 needs more explanations.
It does not hurt to have this option.

> Acked-by: Christophe Fergeau <cfergeau@xxxxxxxxxx>
> 
> Christophe
> 

Frediano
_______________________________________________
Spice-devel mailing list
Spice-devel@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/spice-devel




[Index of Archives]     [Linux Virtualization]     [Linux Virtualization]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Security]     [Bugtraq]     [Linux OMAP]     [Linux MIPS]     [ECOS]     [Asterisk Internet PBX]     [Linux API]     [Monitors]