Re: [PATCH spice-common 8/9] protocol: Add a dummy TunnelChannel

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 3/3/19 9:10 PM, Frediano Ziglio wrote:
The removal of the channel definition will cause the enumeration
to miss this old channel.
Add a dummy channel (empty) to avoid having to update spice-gtk
and spice-server and possibly breaking other software.

Hi Freidano,

This patch should be applied earlier, such that nothing
breaks when previous patches are applied.

Looks good to me.

Uri.


Signed-off-by: Frediano Ziglio <fziglio@xxxxxxxxxx>
---
  spice.proto | 7 +++++--
  1 file changed, 5 insertions(+), 2 deletions(-)

diff --git a/spice.proto b/spice.proto
index de80b27..1f9f57b 100644
--- a/spice.proto
+++ b/spice.proto
@@ -1235,6 +1235,9 @@ channel RecordChannel : BaseChannel {
      } @declare start_mark;
  };
+channel TunnelChannel {
+};
+
  enum32 vsc_message_type {
      Init = 1,
      Error,
@@ -1357,8 +1360,8 @@ protocol Spice {
      CursorChannel cursor;
      PlaybackChannel playback;
      RecordChannel record;
-    // there used to be a TunnelChannel
-    SmartcardChannel smartcard = 8;
+    TunnelChannel tunnel;
+    SmartcardChannel smartcard;
      UsbredirChannel usbredir;
      PortChannel port;
      WebDAVChannel webdav;


_______________________________________________
Spice-devel mailing list
Spice-devel@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/spice-devel




[Index of Archives]     [Linux Virtualization]     [Linux Virtualization]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Security]     [Bugtraq]     [Linux OMAP]     [Linux MIPS]     [ECOS]     [Asterisk Internet PBX]     [Linux API]     [Monitors]