Re: [PATCH spice-server] Do not use possibly undefined SPICE_CHANNEL_TUNNEL

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi,

On Mon, Feb 25, 2019 at 08:37:23AM +0000, Frediano Ziglio wrote:
> The channel was removed from the protocol and marked as
> obsolete. Potentially will be removed from spice/enums.h
> when regenerated.

Should it really be removed?

> Signed-off-by: Frediano Ziglio <fziglio@xxxxxxxxxx>
> ---
>  server/utils.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/server/utils.c b/server/utils.c
> index b440c0648..d2d3669bd 100644
> --- a/server/utils.c
> +++ b/server/utils.c
> @@ -62,7 +62,7 @@ static const char *const channel_names[] = {
>      [ SPICE_CHANNEL_CURSOR   ] = "cursor",
>      [ SPICE_CHANNEL_PLAYBACK ] = "playback",
>      [ SPICE_CHANNEL_RECORD   ] = "record",
> -    [ SPICE_CHANNEL_TUNNEL   ] = "tunnel",
> +    [ 7 /* SPICE_CHANNEL_TUNNEL */ ] = "tunnel",

I think this is fine anyway.
Acked-by: Victor Toso <victortoso@xxxxxxxxxx>

>      [ SPICE_CHANNEL_SMARTCARD] = "smartcard",
>      [ SPICE_CHANNEL_USBREDIR ] = "usbredir",
>      [ SPICE_CHANNEL_PORT     ] = "port",
> -- 
> 2.20.1
> 
> _______________________________________________
> Spice-devel mailing list
> Spice-devel@xxxxxxxxxxxxxxxxxxxxx
> https://lists.freedesktop.org/mailman/listinfo/spice-devel

Attachment: signature.asc
Description: PGP signature

_______________________________________________
Spice-devel mailing list
Spice-devel@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/spice-devel

[Index of Archives]     [Linux Virtualization]     [Linux Virtualization]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Security]     [Bugtraq]     [Linux OMAP]     [Linux MIPS]     [ECOS]     [Asterisk Internet PBX]     [Linux API]     [Monitors]