Hi, On Tue, Feb 19, 2019 at 05:37:38PM +0100, Marc-André Lureau wrote: > > > > - SPICE_DEBUG("frame mm_time %u size %u creation time %" > > > > G_GINT64_FORMAT > > > > - " decoded time %" G_GINT64_FORMAT " queue %u", > > > > - frame->mm_time, frame->size, frame->creation_time, > > > > - duration, decoder->decoding_queue->length); > > > > + record(frames_stats, > > > > + "frame mm_time %u size %u creation time %" PRId64 > > > > + " decoded time %" PRId64 " queue %u", > > > > + frame->mm_time, frame->size, frame->creation_time, > > > > + duration, decoder->decoding_queue->length); > > > > > > Why SPICE_DEBUG log is removed? > > > > > > Why is the "recorder" stuff necessary here? > > > > > > > Measurement instrumentation > > Ok, but can we get have the regular log as well? This really is measurement type of logs. We don't have structured logging so I do prefer this kind of logging being enabled by some dynamic tweaking instead of seeing it all the time.
Attachment:
signature.asc
Description: PGP signature
_______________________________________________ Spice-devel mailing list Spice-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/spice-devel