Hi,
On Tue, Feb 12, 2019 at 11:19:16AM -0500, Frediano Ziglio wrote:
> > > -makecheck-meson:
> > > +fedora-meson:
> > > script:
> > > - - meson build || (cat build/meson-logs/meson-log.txt && exit 1)
> > > - - ninja -C build
> > > - - (cd build && meson test) || (cat build/meson-logs/testlog.txt && exit
> > > 1)
> > > + - meson _build_default || (cat _build_default/meson-logs/meson-log.txt
> > > && exit 1)
> >
> > Why the change to _build_default instead of build?
> > I suppose to group them but why the initial underscore?
> > Why not deleting the directory every time to reduce disk space?
> >
>
> I got also the multiple directories, in the last patch you same
> the logs as artifacts!
>
> But still I don't get the initial underscore.
Maybe some unwritten rule. It is not usual to have initial '_' in
projects, so it is good for temporary folders. I've seen that in
other projects that I contribute and I thought in try it here, I
don't mind removing it.
> Also would be better to use dash instead to have
> build-spice-protocol and not build_spice-protocol.
I like using '-' too, but here the distinction was
build_+$project_name. I'll change it as I really don't care
either way.
Thanks for reviews.
Ah, yes, you asked somewhere, in the cover letter there is the
link for what this looks like, etc. Adding it here again:
https://gitlab.freedesktop.org/victortoso/spice-gtk/pipelines/18709
>
> > > + - ninja -C _build_default
> > > + - ninja -C _build_default test || (cat
> > > _build_default/meson-logs/testlog.txt && exit 1)
> > >
> > > -makecheck_simple:
> > > - script:
> > > - - ./autogen.sh --enable-static
> > > - --enable-lz4=no
> > > - --enable-webdav=no
> > > - --with-sasl=no
> > > - --with-coroutine=auto
> > > - --enable-pulse=no
> > > - --enable-smartcard=no
> > > - --enable-usbredir=no
> > > - - make -j4
> > > - - make check
> > > -
> > > -makecheck_simple-meson:
> > > - script:
> > > - - meson build -Dauto_features=disabled || (cat
> > > build/meson-logs/meson-log.txt && exit 1)
> > > - - ninja -C build
> > > - - (cd build && meson test) || (cat build/meson-logs/testlog.txt && exit
> > > 1)
> > > + - meson _build_feat_disabled -Dauto_features=disabled || (cat
> > > _build_feat_disabled/meson-logs/meson-log.txt && exit 1)
> > > + - ninja -C _build_feat_disabled
> > > + - ninja -C _build_feat_disabled test || (cat
> > > _build_feat_disabled/meson-logs/testlog.txt && exit 1)
> > >
> > > -make-win:
> > > +windows-autotools:
> > > script:
> > > - - dnf install -y mingw64-gcc mingw64-pkg-config mingw64-pixman
> > > mingw64-openssl mingw64-gtk3 mingw64-json-glib mingw64-opus
> > > mingw64-gstreamer1-plugins-base mingw64-gstreamer1-plugins-good
> > > - - (cd spice-protocol && make clean && mingw64-configure --prefix=/usr &&
> > > make install)
> > > - - NOCONFIGURE=yes ./autogen.sh
> > > - - PYTHON=python3 mingw64-configure --enable-static
> > > - - make -j4
> > > + - dnf install -y mingw64-gcc mingw64-pkg-config mingw64-pixman
> > > mingw64-openssl mingw64-gtk3 mingw64-json-glib mingw64-opus
> > > mingw64-gstreamer1-plugins-base mingw64-gstreamer1-plugins-good
> > > + - (cd spice-protocol && make clean && mingw64-configure --prefix=/usr
> > > &&
> > > make install)
> > > + - NOCONFIGURE=yes ./autogen.sh
> > > + - PYTHON=python3 mingw64-configure --enable-static
> > > + - make -j4
Attachment:
signature.asc
Description: PGP signature
_______________________________________________ Spice-devel mailing list Spice-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/spice-devel