Hi On Thu, Jan 31, 2019 at 7:18 PM Frediano Ziglio <fziglio@xxxxxxxxxx> wrote: > > > On Thu, Jan 31, 2019 at 08:37:14AM -0500, Frediano Ziglio wrote: > > > > On Thu, Jan 31, 2019 at 10:34:27AM +0000, Frediano Ziglio wrote: > > > > > Having the RPM spec file produced by the build is helpful in > > > > > different situation. Different tools like mock or code > > > > > scanners accept source RPMs as input. > > > > > Providing this file allows easily build of the source RPM (and > > > > > binaries) using a simple command like > > > > > > > > > > $ rpmbuild -ta spice-protocol-XXXX.tar.bz2 > > > > > > > > > > The spec proposed is a port of current Red Hat spec combining with > > > > > MingW one which allows to build MingW packages easily with a > > > > > > > > > > $ rpmbuild --with mingw -ta spice-protocol-XXXX.tar.bz2 > > > > > > > > > > Signed-off-by: Frediano Ziglio <fziglio@xxxxxxxxxx> > > > > > > > > Are you planning to push for this file to be used for RHEL/fedora > > > > builds? Or is this going to be a 3rd spec file to maintain? > > > > > > > > Christophe > > > > > > > > > > It would be great to have a single one. > > > I don't know if this is technically possible and how to do it. > > > I think fedpkg requires to have the spec in the git repository, > > > I suppose we can say to copy and save from the project repository > > > one. > > > > I'm not asking that fedpkg gets the .spec file from the tarball and use > > that, I'm merely asking if you have plans to unify the file used in > > fedora/rhel and in the tarball. It's fine with me if the same file is > > committed to 3 different places (upstream git, fedora dist-git, rhel > > dist-git). I'm less fine with these 3 spec files being maintained > > separately with arbitrary differences. > > > > Christophe > > > > My idea was to have one. The one I sent seems different from everything > but it is just because is a single one for both MingW and not MingW, if > you remove the MingW part is (except the changelog) exactly the same as > Fedora version. > As discussed on IRC probably the packager could want to add some > patches or other minor changes so it's reasonable if the spec get > changed but I would try to keep it in sync with the upstream one. > I should probably separate and have an initial spec with just Fedora > version and then add (if agreed) the MingW part. > > I also wanted to know what people think about having a spec file > upstream as all our project don't have it. I personally think this has nothing to do in upstream projects. Some people may find it convenient. For the projects I maintain, I opt out. cheers > > Frediano > _______________________________________________ > Spice-devel mailing list > Spice-devel@xxxxxxxxxxxxxxxxxxxxx > https://lists.freedesktop.org/mailman/listinfo/spice-devel -- Marc-André Lureau _______________________________________________ Spice-devel mailing list Spice-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/spice-devel