Re: [PATCH] usbredirserver: Make compile under MacOS

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



> On Wed, Jan 23, 2019 at 10:09:25AM +0000, Frediano Ziglio wrote:
> > This fixes Gitlab issue #9
> > (cfr https://gitlab.freedesktop.org/spice/usbredir/issues/9).
> > 
> > Signed-off-by: Frediano Ziglio <fziglio@xxxxxxxxxx>
> > ---
> >  usbredirserver/usbredirserver.c | 7 +++++++
> >  1 file changed, 7 insertions(+)
> > 
> > diff --git a/usbredirserver/usbredirserver.c
> > b/usbredirserver/usbredirserver.c
> > index 6aa2740..429985a 100644
> > --- a/usbredirserver/usbredirserver.c
> > +++ b/usbredirserver/usbredirserver.c
> > @@ -43,6 +43,13 @@
> >  
> >  #define SERVER_VERSION "usbredirserver " PACKAGE_VERSION
> >  
> > +#if !defined(SOL_TCP) && defined(IPPROTO_TCP)
> > +#define SOL_TCP IPPROTO_TCP
> > +#endif
> > +#if !defined(TCP_KEEPIDLE) && defined(TCP_KEEPALIVE)
> > +#define TCP_KEEPIDLE TCP_KEEPALIVE
> > +#endif
> 
> Might be better to restrict this to OSX in case a system decides to
> use TCP_KEEPALIVE, but with a different meaning?
> 

So

#if !defined(TCP_KEEPIDLE) && defined(TCP_KEEPALIVE) && defined(__APPLE__)

would be fine?

> Looks good otherwise,
> Acked-by: Christophe Fergeau <cfergeau@xxxxxxxxxx>
> 
> Christophe
> 
> > +
> >  static int verbose = usbredirparser_info;
> >  static int client_fd, running = 1;
> >  static libusb_context *ctx;

Frediano
_______________________________________________
Spice-devel mailing list
Spice-devel@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/spice-devel




[Index of Archives]     [Linux Virtualization]     [Linux Virtualization]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Security]     [Bugtraq]     [Linux OMAP]     [Linux MIPS]     [ECOS]     [Asterisk Internet PBX]     [Linux API]     [Monitors]