Hi, > > If the above explains things better to you I should probably replace the > > commit message with that. > > This is actually my first review of a driver that I'm not familiar with. > I'm not quite sure how much in depth understanding that is required to > put my ack on it. Usually I try to show that by picking either Reviewed-by (I'm confident the changes are fine) or Acked-by (Changes look sane, but I don't know the code base and/or hardware good enough to be sure). > Going further into the patchset I realised that > there's no way that I can verify the logic without being intimate with > the driver. Yep. Same for me when looking at patches for other drivers. I think this is one reason why it isn't that easy to get patches for drivers reviewed where effectively only a single maintainer/developer is working on. > I liked your expanded explanation better. Updated the commit message. cheers, Gerd _______________________________________________ Spice-devel mailing list Spice-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/spice-devel