Re: [PATCH spice-common] meson: fix building for big-endian host

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



> 
> From: Marc-André Lureau <marcandre.lureau@xxxxxxxxxx>
> 
> autofoo build-sys defines WORDS_BIGENDIAN, and spice-common code uses it.
> 
> Later, I think it would make sense to switch to G_BIG_ENDIAN instead.
> 

This comment should not be in the commit message.

IMHO WORDS_BIGENDIAN is fine, is pretty standard and Meson is currently
providing definitions in the Autoconf style as it's quite standard.

> Fixes:
> https://gitlab.freedesktop.org/spice/spice-common/issues/2
> 
> Signed-off-by: Marc-André Lureau <marcandre.lureau@xxxxxxxxxx>
> ---
>  meson.build | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/meson.build b/meson.build
> index 049409b..8579680 100644
> --- a/meson.build
> +++ b/meson.build
> @@ -33,6 +33,9 @@ spice_common_config_data = configuration_data()
>  if get_option('extra-checks')
>    spice_common_config_data.set('ENABLE_EXTRA_CHECKS', '1')
>  endif
> +if host_machine.endian() == 'big'
> +  spice_common_config_data.set('WORDS_BIGENDIAN', '1')
> +endif
>  
>  spice_common_generate_code = get_option('generate-code')
>  spice_common_generate_client_code = spice_common_generate_code == 'all' or
>  spice_common_generate_code == 'client'

Frediano
_______________________________________________
Spice-devel mailing list
Spice-devel@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/spice-devel




[Index of Archives]     [Linux Virtualization]     [Linux Virtualization]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Security]     [Bugtraq]     [Linux OMAP]     [Linux MIPS]     [ECOS]     [Asterisk Internet PBX]     [Linux API]     [Monitors]