Hi On Wed, Jan 16, 2019 at 2:47 PM james harvey <jamespharvey20@xxxxxxxxx> wrote: > > On Wed, Jan 16, 2019 at 4:10 AM Victor Toso <victortoso@xxxxxxxxxx> wrote: > > > > From: Victor Toso <me@xxxxxxxxxxxxxx> > > > > Similar to 172c521271a3d - if we don't, the agent might be waiting for > > data till some timeout happens in the system, blocking copy-paste > > feature and possibly freezing applications. > > > > A way to reproduce is copy-paste big clipboard data between two spice > > clients. > > > > Also add some documentation to the checks, in order to quickly > > understand what they are about. > > > > Related: https://gitlab.freedesktop.org/spice/win32/vd_agent/issues/6 > > Related: https://gitlab.freedesktop.org/spice/linux/vd_agent/issues/9 > > Related: https://bugzilla.redhat.com/show_bug.cgi?id=1594876 > > > > v1 -> v2: > > - Fixed comment on s->clipboard_by_guest[selection] check (Marc-André) > > - Removed the reply on read only. (Marc-André) > > > > Signed-off-by: Victor Toso <victortoso@xxxxxxxxxx> > > Am I understanding correctly that the Jan 10 patches which completely > fix spice for me and others experiencing clipboard problems aren't > being added in any form, and that instead the clipboard is being left > broken, just less broken so it doesn't freeze the guest? I don't know > exactly when it broke, but spice didn't used to act this way. That's important information, because spice-gtk clipboard code didn't change that much afaik. > > This patch (v2) alone, on top of current git (ecf9358) at least fixes > the freezing. But, if that's all that's added, it's not something I > can stand using. It doesn't help the clipboard problems. It makes me > want to break my keyboard. Paste randomly failing this often is > extremely frustrating and distracting. > > Log of it breaking after a single paste, so the second one fails is > here: https://termbin.com/5d69 > > The last spice-git I ran was f18589b with the Jan 10 patches: > * [spice-gtk v3 1/3] gtk-session: clipboard: document owner-changed event > * [spice-gtk v3 2/3] gtk-session: clipboard: x11: owner-change improvement > * [spice-gtk v3 3/3] gtk-session: clipboard: x11: do not request data > while on focus > * [spice-gtk] gtk-session: prefer early check to agent > connectivity > > That was rock solid. I have no clipboard problems. Cool! now we need to have clear understanding for the changes to accept them upstream, that's what we are working on. > > That's going to leave me and others perpetually patching spice > releases, and someday when they don't apply cleanly, being at a loss > and being forced to look at other protocols. > > Apologies if I'm misunderstanding. You misunderstand, there is a lot of activity on this problem atm and it is currently scheduled for 0.36. However, since it is not clear whether this is a regression and the fixes are *not* trivial, it should be fine to schedule for 0.37. Either early release after that, and fixes can be backported too most probably. -- Marc-André Lureau _______________________________________________ Spice-devel mailing list Spice-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/spice-devel