Hi, On Wed, Jan 16, 2019 at 04:15:50AM -0500, Frediano Ziglio wrote: > > > > Hi, > > > > For some reason I miss in my inbox the 6/7 patch. Looking at, > > seems that mailman got it. > > > > https://lists.freedesktop.org/archives/spice-devel/2019-January/047268.html > > > > My only suggestion is to move the test to root directory instead > > of srcdir. I'd prefer also to use the glib test framework [0] but > > Do you mean src/, a new tests/ directory (not under src/) or just > with configure.ac and such? Yes, tests/ side-by-side with src/ Not sure what you mean by `with configure.ac` > > tbh, from basically zero tests to 1, we can improve later if > > needed :) > > > > [0] https://developer.gnome.org/glib/stable/glib-Testing.html > > > > Is using some, but currently they are not separate tests, each > part (or most of them) rely on the previous executed so > skipping some would make other fails. No worries, > > > Besides the location for the test, for the series > > Acked-by: Victor Toso <victortoso@xxxxxxxxxx> > > > > On Tue, Jan 15, 2019 at 06:49:56PM +0000, Frediano Ziglio wrote: > > > Correct invalid value for a file descriptor is -1, not 0. > > > > > > Signed-off-by: Frediano Ziglio <fziglio@xxxxxxxxxx> > > > --- > > > src/vdagent/file-xfers.c | 1 + > > > 1 file changed, 1 insertion(+) > > > > > > diff --git a/src/vdagent/file-xfers.c b/src/vdagent/file-xfers.c > > > index b5aedd0..78d5db3 100644 > > > --- a/src/vdagent/file-xfers.c > > > +++ b/src/vdagent/file-xfers.c > > > @@ -133,6 +133,7 @@ static AgentFileXferTask *vdagent_parse_start_msg( > > > goto error; > > > } > > > task = g_new0(AgentFileXferTask, 1); > > > + task->file_fd = -1; > > > task->id = msg->id; > > > task->file_name = g_key_file_get_string( > > > keyfile, "vdagent-file-xfer", "name", &error); > > Frediano
Attachment:
signature.asc
Description: PGP signature
_______________________________________________ Spice-devel mailing list Spice-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/spice-devel