Re: [PATCH spice-gtk v2 02/15] build-sys: deprecate the pulseaudio backend

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi,

On Wed, Jan 09, 2019 at 10:09:22AM +0000, Frediano Ziglio wrote:
> From: Marc-André Lureau <marcandre.lureau@xxxxxxxxxx>
> 
> The PulseAudio audio backend is still the default. However, it will be
> deprecated in favour of the GStreamer backend in a future release.
> 
> Then PulseAudio will be disabled by default, and later on removed.
> 
> Signed-off-by: Marc-André Lureau <marcandre.lureau@xxxxxxxxxx>

Acked-by: Victor Toso <victortoso@xxxxxxxxxx>

After double checking
    https://lists.freedesktop.org/archives/spice-devel/2019-January/046848.html

The other patch should change to a debug instead of warning as
per teuf's request, I'll comment there later.

> ---
>  configure.ac | 3 +++
>  meson.build  | 1 +
>  2 files changed, 4 insertions(+)
> 
> diff --git a/configure.ac b/configure.ac
> index fdd9788f..85827b1d 100644
> --- a/configure.ac
> +++ b/configure.ac
> @@ -559,3 +559,6 @@ AC_MSG_NOTICE([
>  
>  ])
>  SPICE_PRINT_MESSAGES
> +
> +AS_IF([test "x$enable_pulse" = "xyes"],
> +  AC_MSG_WARN([PulseAudio backend is deprecated and will be removed in a future release]))
> diff --git a/meson.build b/meson.build
> index 4b49a24e..4ade991e 100644
> --- a/meson.build
> +++ b/meson.build
> @@ -155,6 +155,7 @@ endif
>  spice_gtk_has_pulse = false
>  d = dependency('libpulse-mainloop-glib', required: get_option('pulse'))
>  if d.found()
> +  warning('PulseAudio backend is deprecated and will be removed in a future release')
>    spice_glib_deps += d
>    spice_gtk_config_data.set('HAVE_PULSE', '1')
>    spice_gtk_has_pulse = true
> -- 
> 2.20.1
> 
> _______________________________________________
> Spice-devel mailing list
> Spice-devel@xxxxxxxxxxxxxxxxxxxxx
> https://lists.freedesktop.org/mailman/listinfo/spice-devel

Attachment: signature.asc
Description: PGP signature

_______________________________________________
Spice-devel mailing list
Spice-devel@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/spice-devel

[Index of Archives]     [Linux Virtualization]     [Linux Virtualization]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Security]     [Bugtraq]     [Linux OMAP]     [Linux MIPS]     [ECOS]     [Asterisk Internet PBX]     [Linux API]     [Monitors]