> > Hi > > On Tue, Jan 8, 2019 at 3:35 PM Frediano Ziglio <fziglio@xxxxxxxxxx> wrote: > > > > > > > > From: Marc-André Lureau <marcandre.lureau@xxxxxxxxxx> > > > > > > v2.5.1 was released the 2015-11-24. > > > > > > According to repology, from the distro we care about, CentOS 6, > > > openSUSE Leap 42.3 have too old version (0.1.2). > > > > > > > This patch tell me that now we DON'T care about them. > > for upcoming releases > Maybe: According to repology, from the distro we currently care about, CentOS 6, openSUSE Leap 42.3 have too old version (0.1.2) but we are removing support for them in the next release. > > Honestly I don't care any more about CentOS 6. > > Can't OpenSUSE users update to 15.0 version (weird version progress, > > see https://lists.opensuse.org/opensuse-project/2017-04/msg00014.html) ? > > > > > spice-gtk & spice-server will have to be updated to drop > > > USE_SMARTCARD_012. > > > > > > Signed-off-by: Marc-André Lureau <marcandre.lureau@xxxxxxxxxx> > > > --- > > > m4/spice-deps.m4 | 10 ++-------- > > > 1 file changed, 2 insertions(+), 8 deletions(-) > > > > > > diff --git a/m4/spice-deps.m4 b/m4/spice-deps.m4 > > > index c8b0a0f..0281625 100644 > > > --- a/m4/spice-deps.m4 > > > +++ b/m4/spice-deps.m4 > > > @@ -87,14 +87,8 @@ AC_DEFUN([SPICE_CHECK_SMARTCARD], [ > > > have_smartcard=no > > > if test "x$enable_smartcard" != "xno"; then > > > PKG_CHECK_MODULES([SMARTCARD], [libcacard >= 2.5.1], > > > [have_smartcard=yes], [have_smartcard=no]) > > > - if test "x$have_smartcard" = "xno"; then > > > - PKG_CHECK_MODULES([SMARTCARD], [libcacard >= 0.1.2], > > > [have_smartcard=yes have_smartcard_012=yes], [have_smartcard=no]) > > > - fi > > > - if test "x$enable_smartcard" != "xauto" && test "x$have_smartcard" > > > = > > > "xno"; then > > > - AC_MSG_ERROR("Smartcard support requested but libcacard could > > > not be > > > found") > > > - fi > > > - if test "x$have_smartcard_012" = "xyes"; then > > > - AC_DEFINE(USE_SMARTCARD_012, [1], [Define if supporting > > > smartcard > > > proxying without libcacard.h]) > > > + if test "x$enable_smartcard" = "xyes" && test "x$have_smartcard" = > > > "xno"; then > > > + AC_MSG_ERROR([smarcard support explicitly requested, but some > > > required packages are not available]) > > > > Previously was "Smartcard support requested but libcacard could not be > > found", > > is this change intentional? > > No, I did the change in spice-gtk first, but Christophe asked me to do > it in spice-common instead. c&p churn. > > Ack with the current error message instead? > Both are fine for me although the old one is more helpful for the user telling the exact package needed. > > > > > fi > > > if test "x$have_smartcard" = "xyes"; then > > > AC_DEFINE(USE_SMARTCARD, [1], [Define if supporting smartcard > > > proxying]) > > Frediano _______________________________________________ Spice-devel mailing list Spice-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/spice-devel