Re: [PATCH spice-gtk 4/5] widget: gst_size_allocate() is static

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



The patch is good but the message is confusing, there's nothing wrong with
the current code and the function is static with or without that "static" on
the definition. 
Maybe "widget: Make clear gst_size_allocate() is static on definition" ?

I think the patch has nothing to do with the series.

> 
> From: Marc-André Lureau <marcandre.lureau@xxxxxxxxxx>
> 
> Signed-off-by: Marc-André Lureau <marcandre.lureau@xxxxxxxxxx>
> ---
>  src/spice-widget.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/src/spice-widget.c b/src/spice-widget.c
> index 87c1560..a44a6f1 100644
> --- a/src/spice-widget.c
> +++ b/src/spice-widget.c
> @@ -2601,7 +2601,7 @@ static gboolean gst_draw_event(GtkWidget *widget,
> cairo_t *cr, gpointer data)
>      return false;
>  }
>  
> -void gst_size_allocate(GtkWidget *widget, GdkRectangle *a, gpointer data)
> +static void gst_size_allocate(GtkWidget *widget, GdkRectangle *a, gpointer
> data)
>  {
>      SpiceDisplay *display = SPICE_DISPLAY(data);
>      SpiceDisplayPrivate *d = display->priv;

Frediano
_______________________________________________
Spice-devel mailing list
Spice-devel@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/spice-devel




[Index of Archives]     [Linux Virtualization]     [Linux Virtualization]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Security]     [Bugtraq]     [Linux OMAP]     [Linux MIPS]     [ECOS]     [Asterisk Internet PBX]     [Linux API]     [Monitors]