Hi,
On Sat, Jan 05, 2019 at 02:48:57PM +0400, Marc-André Lureau wrote:
> Hi
>
> On Sat, Jan 5, 2019 at 1:59 PM Victor Toso <victortoso@xxxxxxxxxx> wrote:
> >
> > Hi,
> >
> > On Fri, Jan 04, 2019 at 04:48:21PM +0400, marcandre.lureau@xxxxxxxxxx wrote:
> > > From: Marc-André Lureau <marcandre.lureau@xxxxxxxxxx>
> > >
> > > Hi,
> > >
> > > The series drops support for optional GStreamer dependency. Spice
> > > increasingly require GStreamer for audio and video support. GStreamer
> > > is widely available, including in embedded space.
> >
> > I think this is fine indeed, not 100% sure if we shouldn't do a
> > last release without this first. Another question is about
>
> As long as we don't require a too recent GStreamer (only 1.0
> apparently, the rest is checked with GST_CHECK_VERSION), I think it
> should be fine.
>
> > pulseaudio backend. If gstreamer is always enabled, I don't see
> > why we need pulseaudio..
>
> Good point, I thought the the gst backend was inferior to the pulse
> backend wrt volume handling, but you pointed out in commit message
> 808ac1d9b3fd926f660231776d5c66946fda5664 that gst now implements it
> for various elements.
It is inferior regarding left/right volume control. Spice
protocol supports that while our audio pipeline with gstreamer
does not. The best approach is to have that implemented in
GStreamer but I forgot to do it in the end
https://gitlab.freedesktop.org/gstreamer/gst-plugins-base/issues/315
Anyway, I think that likely has low impact. I don't expect many
users changing left/right volume in the guest...
> And with pipewire plan to replace pulseaudio (and using the
> gstreamer elements), I think this is the path forward.
Agree
> I'll work on a patch to remove pulse.
Thanks
>
> >
> > Thanks,
> >
> > > Marc-André Lureau (5):
> > > build-sys: remove autoconf --with-audio=..
> > > build-sys: drop gstaudio option, make GStreamer a requirement
> > > build-sys: drop gstvideo option, make it required
> > > widget: gst_size_allocate() is static
> > > build-sys: fix gir/vapi warnings with GstPipeline
> > >
> > > .gitlab-ci.yml | 4 --
> > > configure.ac | 85 ++++++++++-----------------------
> > > meson.build | 33 ++-----------
> > > meson_options.txt | 10 ----
> > > src/Makefile.am | 18 ++-----
> > > src/channel-display-priv.h | 10 +---
> > > src/channel-display.c | 7 ---
> > > src/meson.build | 14 ++----
> > > src/spice-audio.c | 4 --
> > > src/spice-widget-priv.h | 4 --
> > > src/spice-widget.c | 14 ++----
> > > tools/spicy.c | 8 ----
> > > vapi/Makefile.am | 2 +
> > > vapi/meson.build | 4 +-
> > > vapi/spice-client-glib-2.0.deps | 1 +
> > > 15 files changed, 47 insertions(+), 171 deletions(-)
> > >
> > > --
> > > 2.20.1.2.gb21ebb671b
> > >
> > > _______________________________________________
> > > Spice-devel mailing list
> > > Spice-devel@xxxxxxxxxxxxxxxxxxxxx
> > > https://lists.freedesktop.org/mailman/listinfo/spice-devel
> > _______________________________________________
> > Spice-devel mailing list
> > Spice-devel@xxxxxxxxxxxxxxxxxxxxx
> > https://lists.freedesktop.org/mailman/listinfo/spice-devel
>
>
>
> --
> Marc-André Lureau
Attachment:
signature.asc
Description: PGP signature
_______________________________________________ Spice-devel mailing list Spice-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/spice-devel