Re: [PATCH vd_agent_linux v2 5/7] x11: Add a comment explaining a misleading value

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Jan 04, 2019 at 08:37:03AM +0000, Frediano Ziglio wrote:
> People can think that 32 means 32 bit while is always a long.

"it is always"

> 
> Signed-off-by: Frediano Ziglio <fziglio@xxxxxxxxxx>
> ---
>  src/vdagent/x11.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/src/vdagent/x11.c b/src/vdagent/x11.c
> index c9c2e02..bc37a0e 100644
> --- a/src/vdagent/x11.c
> +++ b/src/vdagent/x11.c
> @@ -727,6 +727,7 @@ static int vdagent_x11_get_selection(struct vdagent_x11 *x11, XEvent *event,
>          len *= sizeof(short);
>          break;
>      case 32:
> +        // on X11 a format of 32 is always a long

Maybe add a comma to ease reading "on X11, a format ..."


Acked-by: Christophe Fergeau <cfergeau@xxxxxxxxxx>

>          len *= sizeof(long);
>          break;
>      }
> -- 
> 2.20.1
> 
> _______________________________________________
> Spice-devel mailing list
> Spice-devel@xxxxxxxxxxxxxxxxxxxxx
> https://lists.freedesktop.org/mailman/listinfo/spice-devel

Attachment: signature.asc
Description: PGP signature

_______________________________________________
Spice-devel mailing list
Spice-devel@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/spice-devel

[Index of Archives]     [Linux Virtualization]     [Linux Virtualization]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Security]     [Bugtraq]     [Linux OMAP]     [Linux MIPS]     [ECOS]     [Asterisk Internet PBX]     [Linux API]     [Monitors]