>
> Hi
>
> On Fri, Jan 4, 2019 at 1:27 PM Frediano Ziglio <fziglio@xxxxxxxxxx> wrote:
> >
> > >
> > > Hi
> > >
> > > On Fri, Jan 4, 2019 at 1:04 PM Frediano Ziglio <fziglio@xxxxxxxxxx>
> > > wrote:
> > > >
> > > > Actually was decided was an internal signal so we agreed to not keep
> > > > it...
> > >
> > > There is no such thing as internal signal, and it wasn't documented as
> > > such either. It is available in 0.35.
> > >
> >
> > Yes, there is, for some reason however was not done that way by mistake
> > so yes, should be added again.
>
> How?
>
How what? If you are a person and not a robot you document that an ABI
is not supposed to be used. For instance libc and the interpreter have
a private ABI between them, Windows kernel does not have a stable ABI
(syscall numbers can change, the ntdll.dll ABI is the stable one).
There are thousand of examples about not stable/private ABIs.
The idea was to not document that signal, probably the patch got lost.
So, yes,
Acked-by: Frediano Ziglio <fziglio@xxxxxxxxxx>
to adding the signal back.
> >
> > > It needs to remains, or you may break users, at runtime, or at compile
> > > time - depending on binding/language.
> > >
> >
> > No, in this case won't break anything.
>
> The vala bindings for example, would break
>
How? They should fix vala then.
> >
> > > If it used to work (to do something useful to some degree), we should
> > > also keep it working.. However, since it was only recently introduced,
> > > and unlikely to be used, its probably fine to make it do nothing...
> > >
> >
> > It's working so you are not fixing anything.
> >
> > > >
> > > > ----- Original Message -----
> > > > > From: "Victor Toso" <victortoso@xxxxxxxxxx>
> > > > > To: "marcandre lureau" <marcandre.lureau@xxxxxxxxxx>
> > > > > Cc: spice-devel@xxxxxxxxxxxxxxxxxxxxx
> > > > > Sent: Friday, 4 January, 2019 9:03:07 AM
> > > > > Subject: Re: [PATCH spice-gtk] display: add back
> > > > > SpiceDisplayChannel::streaming-mode
> > > > >
> > > > > Hi,
> > > > >
> > > > > On Fri, Jan 04, 2019 at 12:57:34PM +0400, marcandre.lureau@xxxxxxxxxx
> > > > > wrote:
> > > > > > From: Marc-André Lureau <marcandre.lureau@xxxxxxxxxx>
> > > > > >
> > > > > > The signal was added in 0.35, but removed in
> > > > > > 8c5bf5dedab3cd5a9c7ac484c0d97d43aeb0056b. We should keep it for a
> > > > > > while with updated documentation and a G_SIGNAL_DEPRECATED flag.
> > > > > >
> > > > > > Signed-off-by: Marc-André Lureau <marcandre.lureau@xxxxxxxxxx>
> > > > >
> > > > > Yes,
> > > > > Acked-by: Victor Toso <victortoso@xxxxxxxxxx>
> > > > >
> > > > > Thanks
> > > > >
> > > > > > ---
> > > > > > src/channel-display.c | 25 +++++++++++++++++++++++++
> > > > > > 1 file changed, 25 insertions(+)
> > > > > >
> > > > > > diff --git a/src/channel-display.c b/src/channel-display.c
> > > > > > index 8c0fe5a..4445c9c 100644
> > > > > > --- a/src/channel-display.c
> > > > > > +++ b/src/channel-display.c
> > > > > > @@ -91,6 +91,7 @@ enum {
> > > > > > SPICE_DISPLAY_INVALIDATE,
> > > > > > SPICE_DISPLAY_MARK,
> > > > > > SPICE_DISPLAY_GL_DRAW,
> > > > > > + SPICE_DISPLAY_STREAMING_MODE,
> > > > > > SPICE_DISPLAY_OVERLAY,
> > > > > >
> > > > > > SPICE_DISPLAY_LAST_SIGNAL,
> > > > > > @@ -455,6 +456,30 @@ static void
> > > > > > spice_display_channel_class_init(SpiceDisplayChannelClass *klass)
> > > > > > 4,
> > > > > > G_TYPE_UINT, G_TYPE_UINT, G_TYPE_UINT,
> > > > > > G_TYPE_UINT);
> > > > > >
> > > > > > + /**
> > > > > > + * SpiceDisplayChannel::streaming-mode:
> > > > > > + * @display: the #SpiceDisplayChannel that emitted the signal
> > > > > > + * @streaming_mode: %TRUE when it's streaming mode
> > > > > > + *
> > > > > > + * Return: handle for the display window if possible
> > > > > > + *
> > > > > > + * The #SpiceDisplayChannel::streaming-mode signal is emitted
> > > > > > when
> > > > > > + * spice server is working in streaming mode.
> > > > > > + *
> > > > > > + * Since: 0.35
> > > > > > + *
> > > > > > + * Deprecated: 0.36: use
> > > > > > #SpiceDisplayChannel::gst-video-overlay
> > > > > > + * instead
> > > > > > + **/
> > > > > > + signals[SPICE_DISPLAY_STREAMING_MODE] =
> > > > > > + g_signal_new("streaming-mode",
> > > > > > + G_OBJECT_CLASS_TYPE(gobject_class),
> > > > > > + G_SIGNAL_DEPRECATED, 0,
> > > > > > + NULL, NULL, NULL,
> > > > > > + G_TYPE_POINTER,
> > > > > > + 1,
> > > > > > + G_TYPE_BOOLEAN);
> > > > > > +
> > > > > > /**
> > > > > > * SpiceDisplayChannel::gst-video-overlay:
> > > > > > * @display: the #SpiceDisplayChannel that emitted the signal
_______________________________________________
Spice-devel mailing list
Spice-devel@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/spice-devel