Re: [PATCH spice-gtk] use G_TYPE_POINTER instead of GST_TYPE_PIPELINE

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Jan 03, 2019 at 04:46:29PM +0200, Snir Sheriber wrote:
> GST_TYPE_PIPELINE is undeclared when gstvideo is disabled

I'd rahter that we keep using the more specific type. Feel free to have
a 
#ifndef HAVE_GST_VIDEO
#define GST_TYPE_PIPELINE G_TYPE_POINTER
#endif
but would that code be used at all if gstreamer is not in use?

Christophe

> 
> Signed-off-by: Snir Sheriber <ssheribe@xxxxxxxxxx>
> ---
>  src/channel-display.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/src/channel-display.c b/src/channel-display.c
> index 2a1d9d1..b0fe57e 100644
> --- a/src/channel-display.c
> +++ b/src/channel-display.c
> @@ -476,7 +476,7 @@ static void spice_display_channel_class_init(SpiceDisplayChannelClass *klass)
>                       g_cclosure_user_marshal_BOOLEAN__POINTER,
>                       G_TYPE_BOOLEAN,
>                       1,
> -                     GST_TYPE_PIPELINE);
> +                     G_TYPE_POINTER);
>  
>      channel_set_handlers(SPICE_CHANNEL_CLASS(klass));
>  }
> -- 
> 2.19.1
> 
> _______________________________________________
> Spice-devel mailing list
> Spice-devel@xxxxxxxxxxxxxxxxxxxxx
> https://lists.freedesktop.org/mailman/listinfo/spice-devel

Attachment: signature.asc
Description: PGP signature

_______________________________________________
Spice-devel mailing list
Spice-devel@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/spice-devel

[Index of Archives]     [Linux Virtualization]     [Linux Virtualization]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Security]     [Bugtraq]     [Linux OMAP]     [Linux MIPS]     [ECOS]     [Asterisk Internet PBX]     [Linux API]     [Monitors]