Re: [PATCH spice-gtk 1/3] meson: use 0.49 support for pie

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



> On Sat, Dec 22, 2018 at 06:53:24PM +0400, marcandre.lureau@xxxxxxxxxx wrote:
> > From: Marc-André Lureau <marcandre.lureau@xxxxxxxxxx>
> > 
> > Fixes
> > WARNING: Use the 'pie' kwarg instead of passing '-fpie' manually to
> > 'spice-client-glib-usb-acl-helper'
> > 
> > Signed-off-by: Marc-André Lureau <marcandre.lureau@xxxxxxxxxx>
> > ---
> >  meson.build     |  2 +-
> >  src/meson.build | 13 +++----------
> >  2 files changed, 4 insertions(+), 11 deletions(-)
> > 
> > diff --git a/meson.build b/meson.build
> > index 4e4bee8..67149e7 100644
> > --- a/meson.build
> > +++ b/meson.build
> > @@ -4,7 +4,7 @@
> >  project('spice-gtk', 'c',
> >           version : run_command('build-aux/git-version-gen',
> >           '${MESON_SOURCE_ROOT}/.tarball-version', check :
> >           true).stdout().strip(),
> >           license : 'LGPLv2.1',
> > -         meson_version : '>= 0.47.2')
> > +         meson_version : '>= 0.49')
> 
> I think I mentioned it before, but to this day meson 0.49 is 24 days
> old. Even if this was enough time to get it landed in f29/f30, when we
> decide to switch to using meson by default, we'll have to settle on a
> widely available version rather than always jumping to the latest one.
> 
> Christophe
> 

Is not clear, are you suggesting to just ignore the warning?
Unfortunately Meson is pretty young and buggy and by design is not possible
to extend it so often the only solution is update it.
I complained also about the need to have it updated too often preventing
to be used by default.
I see some solutions:
- wait for a 1.xx version;
- have a workaround packaging Meson with SPICE so to make sure last version
  is available (they promise to just use plain Python);
- move to a more mature and/or flexible build system;
- only update the required version if really needed, ignoring warnings and
  writing small workarounds (that is maintainable) if possible.

Any suggestion/proposal welcome.

Frediano
_______________________________________________
Spice-devel mailing list
Spice-devel@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/spice-devel




[Index of Archives]     [Linux Virtualization]     [Linux Virtualization]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Security]     [Bugtraq]     [Linux OMAP]     [Linux MIPS]     [ECOS]     [Asterisk Internet PBX]     [Linux API]     [Monitors]