Re: [PATCH spice-server 1/4] test-playback: Remove useless check for "frame"

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 12/21/18 10:58 AM, Frediano Ziglio wrote:
We just fill it up, can't be NULL.

Signed-off-by: Frediano Ziglio <fziglio@xxxxxxxxxx>

Acked-by: Uri Lublin <uril@xxxxxxxxxx>

For the series.

Uri.

---
  server/tests/test-playback.c | 6 ++----
  1 file changed, 2 insertions(+), 4 deletions(-)

diff --git a/server/tests/test-playback.c b/server/tests/test-playback.c
index cbefb9b0..32f091ef 100644
--- a/server/tests/test-playback.c
+++ b/server/tests/test-playback.c
@@ -95,10 +95,8 @@ static void playback_timer_cb(SPICE_GNUC_UNUSED void *opaque)
              frame[i] = (((uint16_t)((1<<14)*sin((t+i)/10))) << 16) + (((uint16_t)((1<<14)*sin((t+i)/10))));
          }
          t += num_samples;
-        if (frame) {
-            spice_server_playback_put_samples(&playback_instance, frame);
-            frame = NULL;
-        }
+        spice_server_playback_put_samples(&playback_instance, frame);
+        frame = NULL;
          get_frame();
      }
      core->timer_start(playback_timer, playback_timer_ms);


_______________________________________________
Spice-devel mailing list
Spice-devel@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/spice-devel




[Index of Archives]     [Linux Virtualization]     [Linux Virtualization]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Security]     [Bugtraq]     [Linux OMAP]     [Linux MIPS]     [ECOS]     [Asterisk Internet PBX]     [Linux API]     [Monitors]