>
> The udev rule already adds SYSTEMD_WANTS=spice-vdagentd.socket
> to the relevant virtio devices, which automatically adds Wants=${device}
> to spice-vdagentd.socket (see 'systemctl show spice-vdagentd.socket').
> Adding a Requisite/After for these ports is at best redundant, and most
> likely wrong as this is causing boot time warnings:
>
> [ INFO ] dev-virtio\x2dports-com.redhat.spice.0.device is not active.
> [DEPEND] Dependency failed for Activation socket for spice guest agent
> daemon.
>
> https://bugzilla.redhat.com/show_bug.cgi?id=1545212
>
> Signed-off-by: Christophe Fergeau <cfergeau@xxxxxxxxxx>
> ---
> Unchanged since v1
>
> data/spice-vdagentd.socket | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/data/spice-vdagentd.socket b/data/spice-vdagentd.socket
> index 613c7ed..f14e662 100644
> --- a/data/spice-vdagentd.socket
> +++ b/data/spice-vdagentd.socket
> @@ -1,8 +1,5 @@
> [Unit]
> Description=Activation socket for spice guest agent daemon
> -# only start the socket if the virtio port device exists
> -Requisite=dev-virtio\x2dports-com.redhat.spice.0.device
> -After=dev-virtio\x2dports-com.redhat.spice.0.device
>
> [Socket]
> ListenStream=/var/run/spice-vdagentd/spice-vdagent-sock
For the reasons specified in previous mails I'm fine with this,
Acked-by: Frediano Ziglio <fziglio@xxxxxxxxxx>
Frediano
_______________________________________________
Spice-devel mailing list
Spice-devel@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/spice-devel