[linux-agent v1 5/5] x11: Avoid dereference of a null pointer

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



From: Victor Toso <me@xxxxxxxxxxxxxx>

Similar to previous patch, found by coverity:
  | var_deref_op: Dereferencing null pointer "prev_conv".

Signed-off-by: Victor Toso <victortoso@xxxxxxxxxx>
---
 src/vdagent/x11.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/vdagent/x11.c b/src/vdagent/x11.c
index 69eed4a..50b6674 100644
--- a/src/vdagent/x11.c
+++ b/src/vdagent/x11.c
@@ -422,7 +422,7 @@ static void vdagent_x11_set_clipboard_owner(struct vdagent_x11 *x11,
                 x11->conversion_req = next_conv;
                 x11->clipboard_data_size = 0;
                 x11->expect_property_notify = 0;
-            } else {
+            } else if (prev_conv != NULL) {
                 prev_conv->next = next_conv;
             }
             free(curr_conv);
-- 
2.19.2

_______________________________________________
Spice-devel mailing list
Spice-devel@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/spice-devel




[Index of Archives]     [Linux Virtualization]     [Linux Virtualization]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Security]     [Bugtraq]     [Linux OMAP]     [Linux MIPS]     [ECOS]     [Asterisk Internet PBX]     [Linux API]     [Monitors]