Re: [PATCH spice-common v2 1/2] test-region: Add missing dependencies

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



> 
> The test uses both GLib and pixman libraries.
> This does not seem to affect Linux but make the test fails under Windows.
> 
> Signed-off-by: Frediano Ziglio <fziglio@xxxxxxxxxx>
> ---
>  tests/Makefile.am | 1 +
>  1 file changed, 1 insertion(+)
> 
> Changes since v1:
> - use SPICE_COMMON_LIBS
> 
> diff --git a/tests/Makefile.am b/tests/Makefile.am
> index 926ac99..f54e394 100644
> --- a/tests/Makefile.am
> +++ b/tests/Makefile.am
> @@ -63,6 +63,7 @@ test_region_CFLAGS =			\
>  	$(NULL)
>  test_region_LDADD =					\
>  	$(top_builddir)/common/libspice-common.la	\
> +	$(SPICE_COMMON_LIBS)				\
>  	$(NULL)
>  
>  # Avoid need for python(pyparsing) by end users

Looks like a bug in libtool. Dependencies are in libspice-common.la and
the real executable (in tests/.libs/test_region.exe) correctly depends
on glib and pixman dll files however the wrapper/launcher generated in
tests/test_region.exe is generated not considering dependencies in
libspice-common.la (one of wrapper job is to add some definitions to
PATH variable).
Still the patch solves the weird issue.

Frediano
_______________________________________________
Spice-devel mailing list
Spice-devel@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/spice-devel




[Index of Archives]     [Linux Virtualization]     [Linux Virtualization]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Security]     [Bugtraq]     [Linux OMAP]     [Linux MIPS]     [ECOS]     [Asterisk Internet PBX]     [Linux API]     [Monitors]