Re: [PATCH vdagent-linux 1/4] build: add GIO dependency

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi,

On Sun, Sep 30, 2018 at 08:05:20PM +0200, Jakub Janků wrote:
> Require UNIX-specific GIO package to build spice-vdagent.
> 
> This package includes:
> 
> - GDBus which is going to be used instead of libdbus in
>   console-kit.c and systemd-login.c
> 
> - I/O stream classes and networking APIs that are going to
>   be used in udscs.c and virtio-port.c instead of low-level
>   POSIX I/O functions dealing with file descriptors.
> 
> Version 2.44 is required because of the follwing definitions:
> - g_input_stream_read_all_*
> - g_output_stream_write_all_*
> - GSimpleIOStream

Looks fine yes, we can probably bump glib related libraries to
the same version in this patch as they are released together.

Would you mind bumping it as well while adding small list such as
in
	https://gitlab.freedesktop.org/spice/spice-gtk/commit/a1fd9ee1c6808ed56

> Signed-off-by: Jakub Janků <jjanku@xxxxxxxxxx>
> ---
>  Makefile.am  | 2 ++
>  configure.ac | 1 +
>  2 files changed, 3 insertions(+)
> 
> diff --git a/Makefile.am b/Makefile.am
> index 3e405bc..fa54bbc 100644
> --- a/Makefile.am
> +++ b/Makefile.am
> @@ -51,6 +51,7 @@ src_spice_vdagentd_CFLAGS =			\
>  	$(PCIACCESS_CFLAGS)			\
>  	$(SPICE_CFLAGS)				\
>  	$(GLIB2_CFLAGS)				\
> +	$(GIO2_CFLAGS)				\
>  	$(PIE_CFLAGS)				\
>  	-I$(srcdir)/src				\
>  	$(NULL)
> @@ -62,6 +63,7 @@ src_spice_vdagentd_LDADD =			\
>  	$(PCIACCESS_LIBS)			\
>  	$(SPICE_LIBS)				\
>  	$(GLIB2_LIBS)				\
> +	$(GIO2_LIBS)				\
>  	$(PIE_LDFLAGS)				\
>  	$(NULL)
>  
> diff --git a/configure.ac b/configure.ac
> index 7cb44db..87eb3c0 100644
> --- a/configure.ac
> +++ b/configure.ac
> @@ -101,6 +101,7 @@ AC_ARG_ENABLE([static-uinput],
>                [enable_static_uinput="no"])
>  
>  PKG_CHECK_MODULES([GLIB2], [glib-2.0 >= 2.34])
> +PKG_CHECK_MODULES([GIO2], [gio-unix-2.0 >= 2.44])
>  PKG_CHECK_MODULES(X, [xfixes xrandr >= 1.3 xinerama x11])
>  PKG_CHECK_MODULES(SPICE, [spice-protocol >= 0.12.13])
>  PKG_CHECK_MODULES(ALSA, [alsa >= 1.0.22])
> -- 
> 2.17.1
> 
> _______________________________________________
> Spice-devel mailing list
> Spice-devel@xxxxxxxxxxxxxxxxxxxxx
> https://lists.freedesktop.org/mailman/listinfo/spice-devel

Attachment: signature.asc
Description: PGP signature

_______________________________________________
Spice-devel mailing list
Spice-devel@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/spice-devel

[Index of Archives]     [Linux Virtualization]     [Linux Virtualization]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Security]     [Bugtraq]     [Linux OMAP]     [Linux MIPS]     [ECOS]     [Asterisk Internet PBX]     [Linux API]     [Monitors]