Hi,
This series seems to have some coding style problems. See output below for
more information:
Message-id: 20181126153036.22414-1-fziglio@xxxxxxxxxx
Subject: [Qemu-devel] [PATCH] spice: Use new SpiceImageCompression definition
Type: series
=== TEST SCRIPT BEGIN ===
#!/bin/bash
BASE=base
n=1
total=$(git log --oneline $BASE.. | wc -l)
failed=0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
commits="$(git log --format=%H --reverse $BASE..)"
for c in $commits; do
echo "Checking PATCH $n/$total: $(git log -n 1 --format=%s $c)..."
if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then
failed=1
echo
fi
n=$((n+1))
done
exit $failed
=== TEST SCRIPT END ===
Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
Switched to a new branch 'test'
0db479d spice: Use new SpiceImageCompression definition
=== OUTPUT BEGIN ===
Checking PATCH 1/1: spice: Use new SpiceImageCompression definition...
ERROR: space prohibited after that open square bracket '['
#26: FILE: ui/spice-core.c:334:
+ [ SPICE_IMAGE_COMPRESSION_OFF ] = "off",
ERROR: space prohibited before that close square bracket ']'
#26: FILE: ui/spice-core.c:334:
+ [ SPICE_IMAGE_COMPRESSION_OFF ] = "off",
ERROR: space prohibited after that open square bracket '['
#27: FILE: ui/spice-core.c:335:
+ [ SPICE_IMAGE_COMPRESSION_AUTO_GLZ ] = "auto_glz",
ERROR: space prohibited before that close square bracket ']'
#27: FILE: ui/spice-core.c:335:
+ [ SPICE_IMAGE_COMPRESSION_AUTO_GLZ ] = "auto_glz",
ERROR: space prohibited after that open square bracket '['
#28: FILE: ui/spice-core.c:336:
+ [ SPICE_IMAGE_COMPRESSION_AUTO_LZ ] = "auto_lz",
ERROR: space prohibited before that close square bracket ']'
#28: FILE: ui/spice-core.c:336:
+ [ SPICE_IMAGE_COMPRESSION_AUTO_LZ ] = "auto_lz",
ERROR: space prohibited after that open square bracket '['
#29: FILE: ui/spice-core.c:337:
+ [ SPICE_IMAGE_COMPRESSION_QUIC ] = "quic",
ERROR: space prohibited before that close square bracket ']'
#29: FILE: ui/spice-core.c:337:
+ [ SPICE_IMAGE_COMPRESSION_QUIC ] = "quic",
ERROR: space prohibited after that open square bracket '['
#30: FILE: ui/spice-core.c:338:
+ [ SPICE_IMAGE_COMPRESSION_GLZ ] = "glz",
ERROR: space prohibited before that close square bracket ']'
#30: FILE: ui/spice-core.c:338:
+ [ SPICE_IMAGE_COMPRESSION_GLZ ] = "glz",
ERROR: space prohibited after that open square bracket '['
#31: FILE: ui/spice-core.c:339:
+ [ SPICE_IMAGE_COMPRESSION_LZ ] = "lz",
ERROR: space prohibited before that close square bracket ']'
#31: FILE: ui/spice-core.c:339:
+ [ SPICE_IMAGE_COMPRESSION_LZ ] = "lz",
total: 12 errors, 0 warnings, 34 lines checked
Your patch has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
=== OUTPUT END ===
Test command exited with code: 1
---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to patchew-devel@xxxxxxxxxx
_______________________________________________
Spice-devel mailing list
Spice-devel@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/spice-devel