> On 27 Nov 2018, at 15:38, Christophe Fergeau <cfergeau@xxxxxxxxxx> wrote: > > On Thu, Nov 22, 2018 at 05:58:01AM -0500, Frediano Ziglio wrote: >>> >>> Hey, >>> >>> On Mon, Nov 19, 2018 at 08:46:04PM +0000, Frediano Ziglio wrote: >>>> From: Christophe de Dinechin <dinechin@xxxxxxxxxx> >>>> >>>> Allow to use recorder library. See https://github.com/c3d/recorder for >>>> details. >>>> The main usage will be to collect statistics while the programs will run. >>>> By default the recorder will be disabled at compile time. >>>> Both autoconf and Meson are supported. >>>> Autoconf requires the addition of SPICE_CHECK_RECORDER call in >>>> configure.ac. >>>> Meson requires to add recorder option. >>> >>> Just by reading that log, I wonder why this is different than what was >>> discussed on the list 18 months ago? For example >>> https://lists.freedesktop.org/archives/spice-devel/2017-June/037952.html >>> >> >> Writing an updated commit message. >> >> One of the reason to discard different solutions (SystemTap, LTTng) was portability. >> We support Linux and Windows mainly. GLib structured was not also ported to Windows. >> >> Although I think some proper simple printf-style and classic filtering (grep) >> would be enough I think most of people preferred to have some ready tools >> to collect and display. > > Ok, so in short, portability (availability on Windows and Linux) and > display tools were 2 important requirements. > >> >>> I would add a few followup patches adding a few statistics as an example >>> of how it would be used, this would probably help with the discussion. >>> >> >> Well, the current include is not wrapping much so the online documentation >> at https://github.com/c3d/recorder still apply. > > I'm not really asking how to use it, but it's very odd to have a patch > adding a new dep without seeing any accompanying patches which need that > dependency. You may want to look there: https://github.com/c3d/spice/tree/smart-streaming. I’m surprised you are not aware of this proposal. Thanks Christophe > > Christophe > _______________________________________________ > Spice-devel mailing list > Spice-devel@xxxxxxxxxxxxxxxxxxxxx > https://lists.freedesktop.org/mailman/listinfo/spice-devel _______________________________________________ Spice-devel mailing list Spice-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/spice-devel