On Fri, Oct 12, 2018 at 01:04:52PM +0100, Frediano Ziglio wrote: > Code generated for demarshallers define and declare some types and > functions. > However these types and functions are also declared separately in > other headers resulting in potential ABI mismatch if the different > declarations do not match. If these "other headers" are spice-common/client_demarshallers.h and spice/server/demarshallers.h, I'd be explicit about what you have in mind. > Using a common header shared between generated code and code using > these functions prevent potentially multiple different declarations. > > Signed-off-by: Frediano Ziglio <fziglio@xxxxxxxxxx> > --- > common/Makefile.am | 1 + > common/client_demarshallers.h | 8 +------- > common/demarshallers.h | 31 +++++++++++++++++++++++++++++++ > common/meson.build | 1 + > python_modules/demarshal.py | 1 + > 5 files changed, 35 insertions(+), 7 deletions(-) > create mode 100644 common/demarshallers.h > > Patch apply on top of cleanup series. > > Maybe would be good to remove client_demarshallers.h and put > function declarations (spice_get_server_channel_parser and > spice_get_client_channel_parser) inside demarshallers.h ? Probably, in which case this commit would mostly become a git mv? Acked-by: Christophe Fergeau <cfergeau@xxxxxxxxxx> Christophe
Attachment:
signature.asc
Description: PGP signature
_______________________________________________ Spice-devel mailing list Spice-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/spice-devel