On Thu, Sep 27, 2018 at 07:31:23PM +0300, Yuri Benditovich wrote: > On Thu, Sep 27, 2018 at 12:12 PM Christophe Fergeau <cfergeau@xxxxxxxxxx> > wrote: > > > > This is an exported function, and if we start returning NULL in some > > > > cases, this is going to break applications using this API :( > > > > > > > > > > > This means we'll need to send commit to gnome-boxes to check returned > > value. > > > In general, when the external application (like gnome-boxes) uses > > spice-gtk > > > and does not create devices that do not have libusb_device, it never > > > find ones. > > > Are there other uses of spice-gtk except of gnome-boxes? > > > > If when you upgrade spice-gtk to a newer version, already installed apps > > which are using spice-gtk start crashing, then I'd call this an ABI > > break, which we want to avoid.. virt-viewer/remote-viewer is another > > user, virt-manager too. > > > > They do not, as remote-viewer and virt-manager do not use this API. > gnome-boxes does and does not check for zero, but there is no way to create > the device without libusb with gnome-boxes. Ah right, this method was added specifically for GNOME Boxes, and since GNOME Boxes does not use the spice-gtk widget, then it will need changes in order to create the virtual cd drive, so preexisting gnome boxes builds should indeed not get unwanted NULL results from this API. Thanks, Christophe
Attachment:
signature.asc
Description: PGP signature
_______________________________________________ Spice-devel mailing list Spice-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/spice-devel