On 09/04/2018 11:57 AM, Victor Toso wrote:
From: Victor Toso <me@xxxxxxxxxxxxxx> It is possible that g_get_user_special_dir() return NULL for G_USER_DIRECTORY_DESKTOP or G_USER_DIRECTORY_DOWNLOAD; This is a sure thing to happen in case xdg-user-dirs hasn't been run yet. Keeping spice-vdagent to run on Initialization stage of X-GNOME-Autostart-Phase could trigger a race with xdg-user-dirs that also runs on Initialization, which is the earliest stage possible. The vd_agent has no real need to run so early and could be moved to a later stage, such as Desktop (4th out of 5). Tested in Fedora 28, without any apparent drawbacks.
Hi, It makes sense to move it up from Initializtion. Why did you choose Desktop ? (I am not against it, just trying to understand). According to documentation [1], if we want spice-vdagent to run before other graphics applications it should run at WindowManager. Also Desktop is for "anything that draws on the desktop", but spice-vdagent does not draw on the desktop. On the other hand moving it to Desktop seems safe (maybe even Applications will be OK (tests required)). [1] https://wiki.gnome.org/Projects/SessionManagement/NewGnomeSession
Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1623947 Signed-off-by: Victor Toso <victortoso@xxxxxxxxxx> --- data/spice-vdagent.desktop | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/data/spice-vdagent.desktop b/data/spice-vdagent.desktop index 3f91af4..47dabf2 100644 --- a/data/spice-vdagent.desktop +++ b/data/spice-vdagent.desktop @@ -5,5 +5,5 @@ Exec=/usr/bin/spice-vdagent Terminal=false Type=Application Categories= -X-GNOME-Autostart-Phase=Initialization +X-GNOME-Autostart-Phase=Desktop NoDisplay=true
_______________________________________________ Spice-devel mailing list Spice-devel@xxxxxxxxxxxxxxxxxxxxx https://lists.freedesktop.org/mailman/listinfo/spice-devel