Re: [PATCH spice-common v2] meson: Make use of compiler.get_supported_arguments()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 08/30/2018 11:58 AM, Eduardo Lima (Etrunko) wrote:
> This avoids adding an extra build flag which may not be supported by the
> compiler.
> 
> Signed-off-by: Eduardo Lima (Etrunko) <etrunko@xxxxxxxxxx>
> ---
>  meson.build | 5 ++---
>  1 file changed, 2 insertions(+), 3 deletions(-)
> 
> diff --git a/meson.build b/meson.build
> index 6fa67dc..5729d12 100644
> --- a/meson.build
> +++ b/meson.build
> @@ -159,9 +159,8 @@ glib_encoded_version = 'GLIB_VERSION_@0@_@1@'.format(glib_major_minor[0], glib_m
>  spice_common_global_cflags += ['-DGLIB_VERSION_MIN_REQUIRED=@0@'.format(glib_encoded_version),
>                                 '-DGLIB_VERSION_MAX_ALLOWED=@0@'.format(glib_encoded_version)]
>  
> -foreach arg : spice_common_global_cflags
> -  add_project_arguments(arg, language : 'c')
> -endforeach
> +add_project_arguments(compiler.get_supported_arguments(spice_common_global_cflags),
> +                      language : 'c')
>  

This can also be done for spice-server and spice-gtk, I am sending
patches for them.

-- 
Eduardo de Barros Lima (Etrunko)
Software Engineer - RedHat
etrunko@xxxxxxxxxx
_______________________________________________
Spice-devel mailing list
Spice-devel@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/spice-devel




[Index of Archives]     [Linux Virtualization]     [Linux Virtualization]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Security]     [Bugtraq]     [Linux OMAP]     [Linux MIPS]     [ECOS]     [Asterisk Internet PBX]     [Linux API]     [Monitors]