Re: [cacard 6/7] cac-aca: Favour g_return_val_if_fail over g_assert

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Aug 10, 2018 at 05:18:15AM -0400, Frediano Ziglio wrote:
> > @@ -1014,7 +1014,8 @@ static struct simpletlv_member aca_properties[1] = {
> >  static struct simpletlv_member *
> >  cac_aca_get_properties(size_t *properties_len)
> >  {
> > -    g_assert_nonnull(properties_len);
> > +    /* FIXME: callers don't handle NULL return value, but it can't happen
> > anyway */
> > +    g_return_val_if_fail(properties_len != NULL, NULL);
> > 
> 
> This new regression does not make sense to me.

Ah, the FIXME: was a note for me, I did not mean to keep this hunk
unchanged in the patch I send for review, but I forgot to change it :)

Christophe

Attachment: signature.asc
Description: PGP signature

_______________________________________________
Spice-devel mailing list
Spice-devel@xxxxxxxxxxxxxxxxxxxxx
https://lists.freedesktop.org/mailman/listinfo/spice-devel

[Index of Archives]     [Linux Virtualization]     [Linux Virtualization]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Security]     [Bugtraq]     [Linux OMAP]     [Linux MIPS]     [ECOS]     [Asterisk Internet PBX]     [Linux API]     [Monitors]